From: Will Thomas <will.thomas@imgtec.com>
To: <linux-crypto@vger.kernel.org>
Cc: Will Thomas <will.thomas@imgtec.com>
Subject: [PATCH 3/6] crypto: img-hash - Reconfigure DMA Burst length
Date: Mon, 11 Jul 2016 10:33:33 +0100 [thread overview]
Message-ID: <1468229616-3888-4-git-send-email-will.thomas@imgtec.com> (raw)
In-Reply-To: <1468229616-3888-1-git-send-email-will.thomas@imgtec.com>
Burst length of 16 drives the hash accelerator out of spec
and causes stability issues in some cases. Reduce this to
stop data being lost.
Signed-off-by: Will Thomas <will.thomas@imgtec.com>
Reviewed-by: James Hartley <james.hartley@imgtec.com>
---
drivers/crypto/img-hash.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-hash.c
index 7fa6aa4..fbed47a 100644
--- a/drivers/crypto/img-hash.c
+++ b/drivers/crypto/img-hash.c
@@ -71,6 +71,7 @@
#define DRIVER_FLAGS_MD5 BIT(21)
#define IMG_HASH_QUEUE_LENGTH 20
+#define IMG_HASH_DMA_BURST 4
#define IMG_HASH_DMA_THRESHOLD 64
#ifdef __LITTLE_ENDIAN
@@ -342,7 +343,7 @@ static int img_hash_dma_init(struct img_hash_dev *hdev)
dma_conf.direction = DMA_MEM_TO_DEV;
dma_conf.dst_addr = hdev->bus_addr;
dma_conf.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
- dma_conf.dst_maxburst = 16;
+ dma_conf.dst_maxburst = IMG_HASH_DMA_BURST;
dma_conf.device_fc = false;
err = dmaengine_slave_config(hdev->dma_lch, &dma_conf);
--
2.1.4
next prev parent reply other threads:[~2016-07-11 9:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 9:33 [PATCH 0/6] crypto: img-hash - fixes and interface changes Will Thomas
2016-07-11 9:33 ` [PATCH 1/6] crypto: img-hash - Fix null pointer exception Will Thomas
2016-07-12 7:41 ` Herbert Xu
2016-07-11 9:33 ` [PATCH 2/6] crypto: img-hash - Fix hash request context Will Thomas
2016-07-12 7:43 ` Herbert Xu
2016-07-13 14:45 ` Will Thomas
2016-07-11 9:33 ` Will Thomas [this message]
2016-07-11 9:33 ` [PATCH 4/6] crypto: img-hash - Add suspend resume hooks for img hash Will Thomas
2016-07-11 9:33 ` [PATCH 5/6] crypto: img-hash - Add support for export and import Will Thomas
2016-07-12 7:49 ` Herbert Xu
2016-07-13 14:01 ` Will Thomas
2016-07-18 6:13 ` Herbert Xu
2016-07-11 9:33 ` [PATCH 6/6] crypto: img-hash - log a successful probe Will Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468229616-3888-4-git-send-email-will.thomas@imgtec.com \
--to=will.thomas@imgtec.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).