Re: [PATCH] crypto: mxs-dcp - Remove hash support

[Gianfranco Costamagna <locutusofborg@debian.org>]

Hi,
(sending with my debian.org mail address to avoid spam filters)
I tested the patch and indeed solves my problem (the driver loads correctly now with no warnings)

Tested-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>'


Just a side note about the patch

 
        if (sdcp->caps & MXS_DCP_CAPABILITY1_SHA1) {
                ret = crypto_register_ahash(&dcp_ sha1_alg);
                if (ret) {
                        dev_err(dev, "Failed to register %s hash!\n",
                                 dcp_sha1_alg.halg.base.cra_ name);
                        goto err_unregister_aes;
                }


-err_unregister_aes:
-       if (sdcp->caps & MXS_DCP_CAPABILITY1_AES128)
-               crypto_unregister_algs(dcp_ae s_algs, ARRAY_SIZE(dcp_aes_algs));
-
 err_destroy_aes_thread:
        kthread_stop(sdcp->thread[DCP_ CHAN_CRYPTO]);



seems that in case of SHA1 register failure, the unregister was done on aes algorithm.

Probably a bad copy-paste, but removing such code will obviously fix it.


thanks,
Gianfranco