From: Shannon Nelson <shannon.nelson@oracle.com>
To: linux-crypto@vger.kernel.org
Cc: sparclinux@vger.kernel.org, herbert@gondor.apana.org.au,
linux-kernel@vger.kernel.org,
Shannon Nelson <shannon.nelson@oracle.com>
Subject: [PATCH 1/4] n2rng: limit error spewage when self-test fails
Date: Thu, 12 Jan 2017 10:52:46 -0800 [thread overview]
Message-ID: <1484247169-245086-2-git-send-email-shannon.nelson@oracle.com> (raw)
In-Reply-To: <1484247169-245086-1-git-send-email-shannon.nelson@oracle.com>
If the self-test fails, it probably won't actually suddenly
start working. Currently, this causes an endless spew of
error messages on the console and in the logs, so this patch
adds a limiter to the test.
Reported-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
---
drivers/char/hw_random/n2-drv.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
index 3b06c1d..102560f 100644
--- a/drivers/char/hw_random/n2-drv.c
+++ b/drivers/char/hw_random/n2-drv.c
@@ -589,6 +589,7 @@ static void n2rng_work(struct work_struct *work)
{
struct n2rng *np = container_of(work, struct n2rng, work.work);
int err = 0;
+ static int retries = 4;
if (!(np->flags & N2RNG_FLAG_CONTROL)) {
err = n2rng_guest_check(np);
@@ -606,7 +607,9 @@ static void n2rng_work(struct work_struct *work)
dev_info(&np->op->dev, "RNG ready\n");
}
- if (err && !(np->flags & N2RNG_FLAG_SHUTDOWN))
+ if (--retries == 0)
+ dev_err(&np->op->dev, "Self-test retries failed, RNG not ready\n");
+ else if (err && !(np->flags & N2RNG_FLAG_SHUTDOWN))
schedule_delayed_work(&np->work, HZ * 2);
}
--
1.7.1
next prev parent reply other threads:[~2017-01-12 18:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 18:52 [PATCH 0/4] n2rng: add support for m5/m7 rng register layout Shannon Nelson
2017-01-12 18:52 ` Shannon Nelson [this message]
2017-01-12 18:52 ` [PATCH 2/4] n2rng: add device data descriptions Shannon Nelson
2017-01-12 18:52 ` [PATCH 3/4] n2rng: support new hardware register layout Shannon Nelson
2017-01-12 18:52 ` [PATCH 4/4] n2rng: update version info Shannon Nelson
2017-01-13 14:37 ` [PATCH 0/4] n2rng: add support for m5/m7 rng register layout Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484247169-245086-2-git-send-email-shannon.nelson@oracle.com \
--to=shannon.nelson@oracle.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox