linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/crypto/ccp: return NULL instead of 0
@ 2017-05-03  4:02 Pushkar Jambhlekar
  2017-06-19  6:39 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Pushkar Jambhlekar @ 2017-05-03  4:02 UTC (permalink / raw)
  To: Tom Lendacky, Gary Hook, Herbert Xu, David S. Miller
  Cc: open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER, open list,
	Pushkar Jambhlekar

This change is to handle sparse warning. Return type of function is a pointer to the structure and
it returns 0. Instead it should return NULL.

Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
 drivers/crypto/ccp/ccp-platform.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/ccp/ccp-platform.c b/drivers/crypto/ccp/ccp-platform.c
index 351f28d8..e26969e 100644
--- a/drivers/crypto/ccp/ccp-platform.c
+++ b/drivers/crypto/ccp/ccp-platform.c
@@ -44,7 +44,7 @@ static struct ccp_vdata *ccp_get_of_version(struct platform_device *pdev)
 	if (match && match->data)
 		return (struct ccp_vdata *)match->data;
 #endif
-	return 0;
+	return NULL;
 }
 
 static struct ccp_vdata *ccp_get_acpi_version(struct platform_device *pdev)
@@ -56,7 +56,7 @@ static struct ccp_vdata *ccp_get_acpi_version(struct platform_device *pdev)
 	if (match && match->driver_data)
 		return (struct ccp_vdata *)match->driver_data;
 #endif
-	return 0;
+	return NULL;
 }
 
 static int ccp_get_irq(struct ccp_device *ccp)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/crypto/ccp: return NULL instead of 0
  2017-05-03  4:02 [PATCH] drivers/crypto/ccp: return NULL instead of 0 Pushkar Jambhlekar
@ 2017-06-19  6:39 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2017-06-19  6:39 UTC (permalink / raw)
  To: Pushkar Jambhlekar
  Cc: Tom Lendacky, Gary Hook, David S. Miller,
	open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER, open list

On Wed, May 03, 2017 at 09:32:09AM +0530, Pushkar Jambhlekar wrote:
> This change is to handle sparse warning. Return type of function is a pointer to the structure and
> it returns 0. Instead it should return NULL.
> 
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-19  6:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-03  4:02 [PATCH] drivers/crypto/ccp: return NULL instead of 0 Pushkar Jambhlekar
2017-06-19  6:39 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).