From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au
Cc: linux-arm-kernel@lists.infradead.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH 1/5] crypto: arm/aes-ce - enable module autoloading based on CPU feature bits
Date: Sun, 21 May 2017 10:23:36 +0000 [thread overview]
Message-ID: <1495362220-30044-2-git-send-email-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <1495362220-30044-1-git-send-email-ard.biesheuvel@linaro.org>
Make the module autoloadable by tying it to the CPU feature bit that
describes whether the optional instructions it relies on are implemented
by the current CPU.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
arch/arm/crypto/aes-ce-glue.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm/crypto/aes-ce-glue.c b/arch/arm/crypto/aes-ce-glue.c
index 883b84d828c5..0f966a8ca1ce 100644
--- a/arch/arm/crypto/aes-ce-glue.c
+++ b/arch/arm/crypto/aes-ce-glue.c
@@ -14,6 +14,7 @@
#include <crypto/aes.h>
#include <crypto/internal/simd.h>
#include <crypto/internal/skcipher.h>
+#include <linux/cpufeature.h>
#include <linux/module.h>
#include <crypto/xts.h>
@@ -425,9 +426,6 @@ static int __init aes_init(void)
int err;
int i;
- if (!(elf_hwcap2 & HWCAP2_AES))
- return -ENODEV;
-
err = crypto_register_skciphers(aes_algs, ARRAY_SIZE(aes_algs));
if (err)
return err;
@@ -451,5 +449,5 @@ static int __init aes_init(void)
return err;
}
-module_init(aes_init);
+module_cpu_feature_match(AES, aes_init);
module_exit(aes_exit);
--
2.7.4
next prev parent reply other threads:[~2017-05-21 10:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 10:23 [PATCH 0/5] crypto: arm - enable module autoloading Ard Biesheuvel
2017-05-21 10:23 ` Ard Biesheuvel [this message]
2018-09-10 6:21 ` [PATCH 1/5] crypto: arm/aes-ce - enable module autoloading based on CPU feature bits Stefan Agner
2018-09-10 7:01 ` Ard Biesheuvel
2018-09-13 6:24 ` Stefan Agner
2018-09-13 7:52 ` Ard Biesheuvel
2017-05-21 10:23 ` [PATCH 2/5] crypto: arm/ghash-ce " Ard Biesheuvel
2017-05-21 10:23 ` [PATCH 3/5] crypto: arm/sha1-ce " Ard Biesheuvel
2017-05-21 10:23 ` [PATCH 4/5] crypto: arm/sha2-ce " Ard Biesheuvel
2017-05-21 10:23 ` [PATCH 5/5] crypto: arm/crc32 " Ard Biesheuvel
2017-06-01 5:06 ` [PATCH 0/5] crypto: arm - enable module autoloading Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495362220-30044-2-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).