From: Gilad Ben-Yossef <gilad@benyossef.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Corbet <corbet@lwn.net>,
David Howells <dhowells@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Gary Hook <gary.hook@amd.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Arnaud Ebalard <arno@natisbad.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Shaohua Li <shli@kernel.org>,
Steve French <sfrench@samba.org>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-crypto@v
Cc: Ofir Drang <ofir.drang@arm.com>, Eric Biggers <ebiggers3@gmail.com>
Subject: [PATCH v5 05/19] crypto: introduce crypto wait for async op
Date: Mon, 14 Aug 2017 18:21:15 +0300 [thread overview]
Message-ID: <1502724094-23305-6-git-send-email-gilad@benyossef.com> (raw)
In-Reply-To: <1502724094-23305-1-git-send-email-gilad@benyossef.com>
Invoking a possibly async. crypto op and waiting for completion
while correctly handling backlog processing is a common task
in the crypto API implementation and outside users of it.
This patch adds a generic implementation for doing so in
preparation for using it across the board instead of hand
rolled versions.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
CC: Eric Biggers <ebiggers3@gmail.com>
---
crypto/api.c | 13 +++++++++++++
include/linux/crypto.h | 41 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+)
diff --git a/crypto/api.c b/crypto/api.c
index 941cd4c..2a2479d 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -24,6 +24,7 @@
#include <linux/sched/signal.h>
#include <linux/slab.h>
#include <linux/string.h>
+#include <linux/completion.h>
#include "internal.h"
LIST_HEAD(crypto_alg_list);
@@ -595,5 +596,17 @@ int crypto_has_alg(const char *name, u32 type, u32 mask)
}
EXPORT_SYMBOL_GPL(crypto_has_alg);
+void crypto_req_done(struct crypto_async_request *req, int err)
+{
+ struct crypto_wait *wait = req->data;
+
+ if (err == -EINPROGRESS)
+ return;
+
+ wait->err = err;
+ complete(&wait->completion);
+}
+EXPORT_SYMBOL_GPL(crypto_req_done);
+
MODULE_DESCRIPTION("Cryptographic core API");
MODULE_LICENSE("GPL");
diff --git a/include/linux/crypto.h b/include/linux/crypto.h
index 84da997..bb00186 100644
--- a/include/linux/crypto.h
+++ b/include/linux/crypto.h
@@ -24,6 +24,7 @@
#include <linux/slab.h>
#include <linux/string.h>
#include <linux/uaccess.h>
+#include <linux/completion.h>
/*
* Autoloaded crypto modules should only use a prefixed name to avoid allowing
@@ -468,6 +469,45 @@ struct crypto_alg {
} CRYPTO_MINALIGN_ATTR;
/*
+ * A helper struct for waiting for completion of async crypto ops
+ */
+struct crypto_wait {
+ struct completion completion;
+ int err;
+};
+
+/*
+ * Macro for declaring a crypto op async wait object on stack
+ */
+#define DECLARE_CRYPTO_WAIT(_wait) \
+ struct crypto_wait _wait = { \
+ COMPLETION_INITIALIZER_ONSTACK((_wait).completion), 0 }
+
+/*
+ * Async ops completion helper functioons
+ */
+void crypto_req_done(struct crypto_async_request *req, int err);
+
+static inline int crypto_wait_req(int err, struct crypto_wait *wait)
+{
+ switch (err) {
+ case -EINPROGRESS:
+ case -EBUSY:
+ wait_for_completion(&wait->completion);
+ reinit_completion(&wait->completion);
+ err = wait->err;
+ break;
+ };
+
+ return err;
+}
+
+static inline void crypto_init_wait(struct crypto_wait *wait)
+{
+ init_completion(&wait->completion);
+}
+
+/*
* Algorithm registration interface.
*/
int crypto_register_alg(struct crypto_alg *alg);
@@ -1604,5 +1644,6 @@ static inline int crypto_comp_decompress(struct crypto_comp *tfm,
src, slen, dst, dlen);
}
+
#endif /* _LINUX_CRYPTO_H */
--
2.1.4
next prev parent reply other threads:[~2017-08-14 15:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 15:21 [PATCH v5 00/19] simplify crypto wait for async op Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 02/19] crypto: ccp: use -EAGAIN for transient busy indication Gilad Ben-Yossef
2017-08-14 16:55 ` Gary R Hook
2017-08-14 16:55 ` Gary R Hook
[not found] ` <1502724094-23305-3-git-send-email-gilad-6S/DczAoZh3WXxRugSxzZg@public.gmane.org>
2017-08-14 16:55 ` Gary R Hook
2017-08-14 15:21 ` [PATCH v5 03/19] crypto: remove redundant backlog checks on EBUSY Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 04/19] crypto: marvell/cesa: " Gilad Ben-Yossef
2017-08-15 8:16 ` Boris Brezillon
2017-08-14 15:21 ` Gilad Ben-Yossef [this message]
2017-08-15 2:23 ` [PATCH v5 05/19] crypto: introduce crypto wait for async op Jonathan Cameron
2017-08-21 12:49 ` Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 06/19] crypto: move algif to generic async completion Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 07/19] crypto: move pub key " Gilad Ben-Yossef
[not found] ` <1502724094-23305-1-git-send-email-gilad-6S/DczAoZh3WXxRugSxzZg@public.gmane.org>
2017-08-14 15:21 ` [PATCH v5 01/19] crypto: change transient busy return code to -EAGAIN Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 08/19] crypto: move drbg to generic async completion Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 09/19] crypto: move gcm " Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 10/19] crypto: move testmgr " Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 11/19] fscrypt: move " Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 12/19] dm: move dm-verity " Gilad Ben-Yossef
2017-08-19 20:08 ` [dm-devel] " Mikulas Patocka
[not found] ` <alpine.LRH.2.02.1708191605370.2380-Hpncn10jQN4oNljnaZt3ZvA+iT7yCHsGwRM8/txMwJMAicBL8TP8PQ@public.gmane.org>
2017-08-21 12:48 ` Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 13/19] cifs: move " Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 14/19] ima: " Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 15/19] crypto: tcrypt: " Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 16/19] crypto: talitos: " Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 17/19] crypto: qce: " Gilad Ben-Yossef
2017-08-14 15:21 ` [PATCH v5 18/19] crypto: mediatek: " Gilad Ben-Yossef
[not found] ` <1502724094-23305-19-git-send-email-gilad-6S/DczAoZh3WXxRugSxzZg@public.gmane.org>
2017-08-15 5:13 ` Ryder Lee
2017-08-14 15:21 ` [PATCH v5 19/19] crypto: adapt api sample to use async. op wait Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502724094-23305-6-git-send-email-gilad@benyossef.com \
--to=gilad@benyossef.com \
--cc=agk@redhat.com \
--cc=arno@natisbad.org \
--cc=boris.brezillon@free-electrons.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dm-devel@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=ebiggers3@gmail.com \
--cc=gary.hook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=jaegeuk@kernel.org \
--cc=james.l.morris@oracle.com \
--cc=linux-crypto@v \
--cc=matthias.bgg@gmail.com \
--cc=ofir.drang@arm.com \
--cc=serge@hallyn.com \
--cc=sfrench@samba.org \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=tytso@mit.edu \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox