From: Gilad Ben-Yossef <gilad@benyossef.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Corbet <corbet@lwn.net>,
David Howells <dhowells@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Gary Hook <gary.hook@amd.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Arnaud Ebalard <arno@natisbad.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Shaohua Li <shli@kernel.org>,
Steve French <sfrench@samba.org>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Cc: Ofir Drang <ofir.drang@arm.com>
Subject: [PATCH v8 14/20] cifs: move to generic async completion
Date: Tue, 5 Sep 2017 15:38:53 +0300 [thread overview]
Message-ID: <1504615144-29770-15-git-send-email-gilad@benyossef.com> (raw)
In-Reply-To: <1504615144-29770-1-git-send-email-gilad@benyossef.com>
cifs starts an async. crypto op and waits for their completion.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Acked-by: Pavel Shilovsky <pshilov@microsoft.com>
---
fs/cifs/smb2ops.c | 30 ++++--------------------------
1 file changed, 4 insertions(+), 26 deletions(-)
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index fb2934b..982b39d 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -2066,22 +2066,6 @@ init_sg(struct smb_rqst *rqst, u8 *sign)
return sg;
}
-struct cifs_crypt_result {
- int err;
- struct completion completion;
-};
-
-static void cifs_crypt_complete(struct crypto_async_request *req, int err)
-{
- struct cifs_crypt_result *res = req->data;
-
- if (err == -EINPROGRESS)
- return;
-
- res->err = err;
- complete(&res->completion);
-}
-
static int
smb2_get_enc_key(struct TCP_Server_Info *server, __u64 ses_id, int enc, u8 *key)
{
@@ -2122,12 +2106,10 @@ crypt_message(struct TCP_Server_Info *server, struct smb_rqst *rqst, int enc)
struct aead_request *req;
char *iv;
unsigned int iv_len;
- struct cifs_crypt_result result = {0, };
+ DECLARE_CRYPTO_WAIT(wait);
struct crypto_aead *tfm;
unsigned int crypt_len = le32_to_cpu(tr_hdr->OriginalMessageSize);
- init_completion(&result.completion);
-
rc = smb2_get_enc_key(server, tr_hdr->SessionId, enc, key);
if (rc) {
cifs_dbg(VFS, "%s: Could not get %scryption key\n", __func__,
@@ -2187,14 +2169,10 @@ crypt_message(struct TCP_Server_Info *server, struct smb_rqst *rqst, int enc)
aead_request_set_ad(req, assoc_data_len);
aead_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG,
- cifs_crypt_complete, &result);
+ crypto_req_done, &wait);
- rc = enc ? crypto_aead_encrypt(req) : crypto_aead_decrypt(req);
-
- if (rc == -EINPROGRESS || rc == -EBUSY) {
- wait_for_completion(&result.completion);
- rc = result.err;
- }
+ rc = crypto_wait_req(enc ? crypto_aead_encrypt(req)
+ : crypto_aead_decrypt(req), &wait);
if (!rc && enc)
memcpy(&tr_hdr->Signature, sign, SMB2_SIGNATURE_SIZE);
--
2.1.4
next prev parent reply other threads:[~2017-09-05 12:42 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 12:38 [PATCH v8 00/20] simplify crypto wait for async op Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 01/20] crypto: change transient busy return code to -EAGAIN Gilad Ben-Yossef
[not found] ` <1504615144-29770-1-git-send-email-gilad-6S/DczAoZh3WXxRugSxzZg@public.gmane.org>
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 02/20] crypto: ccp: use -EAGAIN for transient busy indication Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 04/20] crypto: remove redundant backlog checks on EBUSY Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 06/20] crypto: introduce crypto wait for async op Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 07/20] crypto: move algif to generic async completion Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 08/20] crypto: move pub key " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 09/20] crypto: move drbg " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 10/20] crypto: move gcm " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 11/20] crypto: move testmgr " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 12/20] fscrypt: move " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 13/20] dm: move dm-verity " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 15/20] ima: move " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 16/20] crypto: tcrypt: " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 17/20] crypto: talitos: " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 18/20] crypto: qce: " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 19/20] crypto: mediatek: " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 20/20] crypto: adapt api sample to use async. op wait Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 01/20] crypto: change transient busy return code to -EAGAIN Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 02/20] crypto: ccp: use -EAGAIN for transient busy indication Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 03/20] net: " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 04/20] crypto: remove redundant backlog checks on EBUSY Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 05/20] crypto: marvell/cesa: " Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 06/20] crypto: introduce crypto wait for async op Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 07/20] crypto: move algif to generic async completion Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 08/20] crypto: move pub key " Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 09/20] crypto: move drbg " Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 10/20] crypto: move gcm " Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 11/20] crypto: move testmgr " Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 12/20] fscrypt: move " Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 13/20] dm: move dm-verity " Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef [this message]
2017-09-05 12:38 ` [PATCH v8 15/20] ima: move " Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 16/20] crypto: tcrypt: " Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 17/20] crypto: talitos: " Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 18/20] crypto: qce: " Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 19/20] crypto: mediatek: " Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
2017-09-05 12:38 ` [PATCH v8 20/20] crypto: adapt api sample to use async. op wait Gilad Ben-Yossef
2017-09-05 12:38 ` Gilad Ben-Yossef
[not found] ` <1504615144-29770-2-git-send-email-gilad@benyossef.com>
[not found] ` <1504615144-29770-2-git-send-email-gilad-6S/DczAoZh3WXxRugSxzZg@public.gmane.org>
2017-10-07 3:05 ` [PATCH v8 01/20] crypto: change transient busy return code to -EAGAIN Herbert Xu
2017-10-07 7:51 ` Gilad Ben-Yossef
2017-10-11 6:26 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504615144-29770-15-git-send-email-gilad@benyossef.com \
--to=gilad@benyossef.com \
--cc=agk@redhat.com \
--cc=arno@natisbad.org \
--cc=boris.brezillon@free-electrons.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dm-devel@redhat.com \
--cc=gary.hook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=jaegeuk@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=matthias.bgg@gmail.com \
--cc=ofir.drang@arm.com \
--cc=sfrench@samba.org \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
--cc=steffen.klassert@secunet.com \
--cc=thomas.lendacky@amd.com \
--cc=tytso@mit.edu \
--cc=yoshfuji@linux-ipv6.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox