From: Joe Perches <joe@perches.com>
To: Varsha Rao <rvarsha016@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: cocci <cocci@systeme.lip6.fr>
Subject: Re: [PATCH] crypto: cavium: zip: Remove unnecessary parentheses
Date: Wed, 28 Mar 2018 11:11:16 -0700 [thread overview]
Message-ID: <1522260676.12357.121.camel@perches.com> (raw)
In-Reply-To: <20180328175736.17360-1-rvarsha016@gmail.com>
On Wed, 2018-03-28 at 23:27 +0530, Varsha Rao wrote:
> This patch fixes the clang warning of extraneous parentheses, with the
> following coccinelle script.
>
> @@
> identifier i;
> constant c;
> @@
> (
> -((i == c))
> +i == c
> >
>
> -((i <= c))
> +i <= c
Why just the "==" and "<=" cases?
Why not "<", ">" and ">=" too?
Why not expression instead of constant?
next prev parent reply other threads:[~2018-03-28 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 17:57 [PATCH] crypto: cavium: zip: Remove unnecessary parentheses Varsha Rao
2018-03-28 18:11 ` Joe Perches [this message]
2018-03-29 15:33 ` Varsha Rao
2018-03-30 20:17 ` Joe Perches
2018-03-31 6:17 ` Julia Lawall
2018-03-31 6:18 ` Julia Lawall
2018-03-31 8:48 ` [Cocci] " Varsha Rao
2018-03-31 8:55 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522260676.12357.121.camel@perches.com \
--to=joe@perches.com \
--cc=cocci@systeme.lip6.fr \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox