Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: 'LKML' <linux-kernel@vger.kernel.org>, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: AEAD: add check for presence of auth tag
Date: Mon, 05 Jan 2015 12:00:36 +0100	[thread overview]
Message-ID: <1533111.7lv9uhtZ5L@tachyon.chronox.de> (raw)
In-Reply-To: <20150105105540.GA25665@gondor.apana.org.au>

Am Montag, 5. Januar 2015, 21:55:40 schrieb Herbert Xu:

Hi Herbert,

> On Mon, Jan 05, 2015 at 11:53:38AM +0100, Stephan Mueller wrote:
> > Could you please check: I am unable to find the function.
> 
> It's in crypto/authenc.c.
> 
> > Note, there is no size parameter provided in crypto_aead_decrypt. To
> > obtain
> > the size, I would need to walk the scatterlists, no?
> 
> The cryptlen is supposed to contain the entire input apart from the
> AD, including the authentication tag if one is present.

Thanks a lot for the pointer, I overlooked the cryptlen member variable. I 
will update the patch to replace the scatterlist walk with such small check.

-- 
Ciao
Stephan

      reply	other threads:[~2015-01-05 11:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-30 21:16 [PATCH] crypto: AEAD: add check for presence of auth tag Stephan Mueller
2015-01-05 10:19 ` Herbert Xu
2015-01-05 10:26   ` Stephan Mueller
2015-01-05 10:39     ` Herbert Xu
2015-01-05 10:53       ` Stephan Mueller
2015-01-05 10:55         ` Herbert Xu
2015-01-05 11:00           ` Stephan Mueller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533111.7lv9uhtZ5L@tachyon.chronox.de \
    --to=smueller@chronox.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox