Re: [V3 PATCH 12/16] powerpc/pseries/vas: sysfs interface to export capabilities

Haren Myneni
2021-05-10T20:52:27Z

On Mon, 2021-05-10 at 16:34 +1000, Nicholas Piggin wrote:
> Excerpts from Haren Myneni's message of April 18, 2021 7:10 am:
> > pHyp provides GZIP default and GZIP QoS capabilities which gives
> > the total number of credits are available in LPAR. This patch
> > creates sysfs entries and exports LPAR credits, the currently used
> > and the available credits for each feature.
> >
> > /sys/kernel/vas/VasCaps/VDefGzip: (default GZIP capabilities)
> > avail_lpar_creds /* Available credits to use */
> > target_lpar_creds /* Total credits available which can be
> > /* changed with DLPAR operation */
> > used_lpar_creds /* Used credits */
>
> /sys/kernel/ is not an appropriate directory to put it in. Also
> camel
> case is not thought very highly of these days.

These capabilities are VAS specific ones (powerpc kernel), not for the
indicidual coprocessor. Not sure where to add in sysfs.

>
> And s/capabs/caps/g applies here (and all other patches).

Thanks, will change.
>
> Thanks,
> Nick