Re: [PATCH v4] crypto: AF_ALG - fix AEAD tag memory handling

["Stephan Müller" <smueller@chronox.de>]

Am Mittwoch, 7. Dezember 2016, 19:42:45 CET schrieb Herbert Xu:

Hi Herbert,
> 
> Hmm, I don't see the code that copies the AAD over.  Did I miss it?

You do not miss it. As I mentioned in a previous email, I would like:

- to include the current patch around the tag now as it has been on the 
mailing list for a long time -- that current patch fixes the superfluous 
copying of the tag value. That fix of the tag handling is unrelated to any AAD 
logic. However, it changes the user-visible memory structure and therefore the 
user interface (i.e. during decryption, the returned data is smaller than it 
used to be and during encryption, less data is required as input).

- the AAD handling with the copying over of data shall come in the next 
development cycle for 4.10. That change is not user visible as it does not 
change the memory structure and thus the user interface. Also, the AAD change 
is unrelated to the tag change provided with this patch.


Ciao
Stephan