Re: [PATCH v3 2/9] crypto/ycc: Add ycc ring configuration

kernel test robot
2022-10-26T11:05:05Z

[-- Attachment #1: Type: text/plain, Size: 4808 bytes --]

Hi 'Guanjun',

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linus/master v6.1-rc2 next-20221026]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Guanjun/Drivers-for-Alibaba-YCC-Yitian-Cryptography-Complex-cryptographic-accelerator/20221025-180005
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link: https://lore.kernel.org/r/1666691616-69983-3-git-send-email-guanjun%40linux.alibaba.com
patch subject: [PATCH v3 2/9] crypto/ycc: Add ycc ring configuration
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/5ca4b99caab6eb8aaae9fa3793f0eb5ad7b4e973
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Guanjun/Drivers-for-Alibaba-YCC-Yitian-Cryptography-Complex-cryptographic-accelerator/20221025-180005
git checkout 5ca4b99caab6eb8aaae9fa3793f0eb5ad7b4e973
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/crypto/ycc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/crypto/ycc/ycc_isr.c:44:6: warning: no previous prototype for 'ycc_resp_process' [-Wmissing-prototypes]
44 | void ycc_resp_process(uintptr_t ring_addr)
| ^~~~~~~~~~~~~~~~
--
drivers/crypto/ycc/ycc_ring.c: In function 'ycc_ring_debugfs_status_show':
>> drivers/crypto/ycc/ycc_ring.c:40:41: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
40 | seq_printf(s, "CMD base addr:%llx, RESP base addr:%llx\n",
| ~~~^
| |
| long long unsigned int
| %x
41 | ring->cmd_base_paddr, ring->resp_base_paddr);
| ~~~~~~~~~~~~~~~~~~~~
| |
| dma_addr_t {aka unsigned int}
drivers/crypto/ycc/ycc_ring.c:40:62: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
40 | seq_printf(s, "CMD base addr:%llx, RESP base addr:%llx\n",
| ~~~^
| |
| long long unsigned int
| %x
41 | ring->cmd_base_paddr, ring->resp_base_paddr);
| ~~~~~~~~~~~~~~~~~~~~~
| |
| dma_addr_t {aka unsigned int}
drivers/crypto/ycc/ycc_ring.c: At top level:
>> drivers/crypto/ycc/ycc_ring.c:518:6: warning: no previous prototype for 'ycc_handle_resp' [-Wmissing-prototypes]
518 | void ycc_handle_resp(struct ycc_ring *ring, struct ycc_resp_desc *desc)
| ^~~~~~~~~~~~~~~
drivers/crypto/ycc/ycc_ring.c: In function 'ycc_handle_resp':
>> drivers/crypto/ycc/ycc_ring.c:524:17: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
524 | aflag = (struct ycc_flags *)desc->private_ptr;
| ^
>> drivers/crypto/ycc/ycc_ring.c:525:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
525 | if (!aflag || (u64)aflag == CMD_INVALID_CONTENT_U64) {
| ^

vim +/ycc_resp_process +44 drivers/crypto/ycc/ycc_isr.c

40
41 /*
42 * TODO: will implement when ycc ring actually work.
43 */
> 44 void ycc_resp_process(uintptr_t ring_addr)
45 {
46 }
47

--
0-DAY CI Kernel Test Service
https://01.org/lkp

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 84023 bytes --]