Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org
Subject: Recent AEAD change: testmgr.c change needed?
Date: Wed, 19 Aug 2015 11:48:05 +0200	[thread overview]
Message-ID: <1732898.70JpgbIL8N@myon.chronox.de> (raw)

Hi Herbert,

The recent AEAD change seems to trigger a need to change something in 
testmgr.c. I ran my test tool trying to invoke all possible permutations of 
cra_name and cra_driver_name ciphers and got the following:

[11152.816179] alg: No test for gcm_base(ctr(aes-asm),ghash-generic) 
(gcm_base(ctr(aes-asm),ghash-generic))
[11154.278466] alg: No test for ccm_base(ctr(aes-asm),aes-asm) 
(ccm_base(ctr(aes-asm),aes-asm))
[11174.819535] alg: No test for gcm(aes-asm) (gcm_base(ctr(aes-asm),ghash-
clmulni))
[11174.819610] alg: No test for rfc4106(gcm(aes-asm)) 
(rfc4106(gcm_base(ctr(aes-asm),ghash-clmulni)))
[11174.819654] alg: No test for seqiv(rfc4106(gcm(aes-asm))) 
(seqiv(rfc4106(gcm_base(ctr(aes-asm),ghash-clmulni))))
[11192.292759] alg: No test for gcm_base(ctr-aes-aesni,ghash-clmulni) 
(gcm_base(ctr-aes-aesni,ghash-clmulni))
[11193.775049] alg: No test for ccm_base(ctr-aes-aesni,aes-aesni) 
(ccm_base(ctr-aes-aesni,aes-aesni))
[11213.936196] alg: No test for gcm(aes-aesni) (gcm_base(ctr(aes-aesni),ghash-
clmulni))
[11213.936308] alg: No test for rfc4106(gcm(aes-aesni)) 
(rfc4106(gcm_base(ctr(aes-aesni),ghash-clmulni)))
[11213.936418] alg: No test for seqiv(rfc4106(gcm(aes-aesni))) 
(seqiv(rfc4106(gcm_base(ctr(aes-aesni),ghash-clmulni))))
[11252.498078] alg: No test for seqiv(rfc4106(gcm(aes))) (seqiv(rfc4106-gcm-
aesni))
[11270.222200] alg: No test for gcm_base(ctr(aes-generic),ghash-generic) 
(gcm_base(ctr(aes-generic),ghash-generic))
[11271.602667] alg: No test for ccm_base(ctr(aes-generic),aes-generic) 
(ccm_base(ctr(aes-generic),aes-generic))


Albeit this listing is a nuisance in normal operation, it becomes fatal in 
fips=1 mode.

I guess we have to add all the listed ciphers into the big array in testmgr.c. 
If you concur, I could prepare a patch.

-- 
Ciao
Stephan

             reply	other threads:[~2015-08-19  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19  9:48 Stephan Mueller [this message]
2015-08-19 12:45 ` Recent AEAD change: testmgr.c change needed? Herbert Xu
2015-08-20  7:34   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1732898.70JpgbIL8N@myon.chronox.de \
    --to=smueller@chronox.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox