From: "Rob Herring (Arm)" <robh@kernel.org>
To: John Ernberg <john.ernberg@actia.se>
Cc: "Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Frank Li" <Frank.li@nxp.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Horia Geantă" <horia.geanta@nxp.com>,
imx@lists.linux.dev, "Fabio Estevam" <festevam@gmail.com>,
linux-kernel@vger.kernel.org, "Shawn Guo" <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Pankaj Gupta" <pankaj.gupta@nxp.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Gaurav Jain" <gaurav.jain@nxp.com>,
"David S . Miller" <davem@davemloft.net>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v4 3/4] dt-bindings: crypto: fsl,sec-v4.0: Add power domains for iMX8QM and iMX8QXP
Date: Thu, 05 Jun 2025 09:29:04 -0500 [thread overview]
Message-ID: <174913374447.2520926.5612887459467477896.robh@kernel.org> (raw)
In-Reply-To: <20250605132754.1771368-4-john.ernberg@actia.se>
On Thu, 05 Jun 2025 13:28:02 +0000, John Ernberg wrote:
> NXP SoCs like the iMX8QM, iMX8QXP or iMX8DXP use power domains for
> resource management.
>
> Add compatible strings for these SoCs (QXP and DXP gets to share as their
> only difference is a core-count, Q=Quad core and D=Dual core), and allow
> power-domains for them only. Keep the old restriction for others.
>
> Signed-off-by: John Ernberg <john.ernberg@actia.se>
>
> ---
>
> v4:
> - Reword commit message (Frank Li)
> - Add explicit imx8qxp compatible (Frank Li)
> - Move the job-ring constraints back to the job-ring section under an
> 'allOf:' to avoid the warning from v2 (Rob Herring)
>
> v3:
> - Fix warnings discovered by Rob Herring's bot
> - Declare the compatibles correctly (Krzysztof Kozlowski)
>
> v2:
> - Adjust commit message (Frank Li)
> - Only allow power-domains when compatible with imx8qm (Frank Li)
> ---
> .../bindings/crypto/fsl,sec-v4.0.yaml | 41 ++++++++++++++++++-
> 1 file changed, 40 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml:115:17: [warning] wrong indentation: expected 18 but found 16 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250605132754.1771368-4-john.ernberg@actia.se
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-06-05 14:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 13:28 [PATCH v4 0/4] crypto: caam - iMX8QXP support (and related fixes) John Ernberg
2025-06-05 13:28 ` [PATCH v4 1/4] crypto: caam - Prevent crash on suspend with iMX8QM / iMX8ULP John Ernberg
2025-06-09 10:45 ` Peng Fan
2025-06-05 13:28 ` [PATCH v4 3/4] dt-bindings: crypto: fsl,sec-v4.0: Add power domains for iMX8QM and iMX8QXP John Ernberg
2025-06-05 13:32 ` John Ernberg
2025-06-05 17:46 ` Rob Herring
2025-06-05 14:29 ` Rob Herring (Arm) [this message]
2025-06-05 17:47 ` Rob Herring (Arm)
2025-06-05 13:28 ` [PATCH v4 4/4] arm64: dts: freescale: imx8qxp/imx8qm: Add CAAM support John Ernberg
2025-06-09 10:49 ` Peng Fan
2025-06-05 13:28 ` [PATCH v4 2/4] crypto: caam - Support iMX8QXP and variants thereof John Ernberg
2025-06-09 10:46 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174913374447.2520926.5612887459467477896.robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gaurav.jain@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=imx@lists.linux.dev \
--cc=john.ernberg@actia.se \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.gupta@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox