From: Ma Yukun <0x4fe6@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Martin Kaiser <martin@kaiser.cx>, linux-crypto@vger.kernel.org
Subject: [PATCH] hwrng: imx-rngc - check return value of clk_prepare_enable()
Date: Sun, 06 Sep 2026 19:36:33 +0800 [thread overview]
Message-ID: <178869459340.2131.17730179758509117031@gmail.com> (raw)
clk_prepare_enable() can fail here and its return value is currently
ignored. If the clock fails to enable, the probe continues to read
from the hardware registers without a clock, which can cause a bus
hang or external abort.
Check the return value and fail probe if the clock cannot be enabled.
Fixes: 1d5449445bd0 ("hwrng: mx-rngc - add a driver for Freescale RNGC")
Signed-off-by: Ma Yukun <0x4fe6@gmail.com>
---
drivers/char/hw_random/imx-rngc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index 7693328f1..58bdc7a6b 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -266,7 +266,9 @@ static int __init imx_rngc_probe(struct platform_device *pdev)
if (irq < 0)
return irq;
- clk_prepare_enable(rngc->clk);
+ ret = clk_prepare_enable(rngc->clk);
+ if (ret)
+ return ret;
ver_id = readl(rngc->base + RNGC_VER_ID);
--
2.43.0
reply other threads:[~2026-09-06 11:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178869459340.2131.17730179758509117031@gmail.com \
--to=0x4fe6@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=martin@kaiser.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox