From: Stephan Mueller <smueller@chronox.de>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org,
'LKML' <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: aesni: add setkey for driver-gcm-aes-aesni
Date: Thu, 22 Jan 2015 22:20:30 +0100 [thread overview]
Message-ID: <1876694.bQrN48MF7q@tauon> (raw)
In-Reply-To: <54C1403D.1010608@intel.com>
Am Donnerstag, 22. Januar 2015, 10:23:57 schrieb Tadeusz Struk:
Hi Tadeusz,
>On 01/20/2015 05:25 PM, Stephan Mueller wrote:
>>> Rather than adding a bogus setkey function, please fix this mess
>>> properly by moving the top-level setkey function into the __driver
>>> one where it should be. Compare with how we handle it in the
>>> ablk_helper which is pretty much the same thing.
>>
>> Tadeusz, are you working on that update or shall I have a look?
>
>Hi,
>No, I thought that the agreement was that we don't want to allow user
>space to use these helpers directly, right? Am I missing something?
That would be correct. But if I understood Herbert correctly, he is
creating a patch that disables these service ciphers for general usage.
Ciao
Stephan
next prev parent reply other threads:[~2015-01-22 21:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 22:56 [PATCH] crypto: aesni: add setkey for driver-gcm-aes-aesni Stephan Mueller
2015-01-18 22:58 ` Stephan Mueller
2015-01-19 14:34 ` Tadeusz Struk
2015-01-20 3:17 ` Herbert Xu
2015-01-20 3:35 ` Stephan Mueller
2015-01-20 3:37 ` Herbert Xu
2015-01-20 3:54 ` Stephan Mueller
2015-01-20 4:03 ` Herbert Xu
2015-01-21 1:25 ` Stephan Mueller
2015-01-22 18:23 ` Tadeusz Struk
2015-01-22 21:20 ` Stephan Mueller [this message]
2015-01-22 21:55 ` Tadeusz Struk
2015-01-22 22:23 ` Herbert Xu
2015-01-22 22:30 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1876694.bQrN48MF7q@tauon \
--to=smueller@chronox.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).