From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Tudor Ambarus <tudor-dan.ambarus@nxp.com>, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v5] crypto: rsa - return raw integers for the ASN.1 parser
Date: Tue, 14 Jun 2016 15:53:15 +0200 [thread overview]
Message-ID: <1920297.cMHx9vzUDS@tauon.atsec.com> (raw)
In-Reply-To: <20160614133806.GA22193@gondor.apana.org.au>
Am Dienstag, 14. Juni 2016, 21:38:06 schrieb Herbert Xu:
Hi Herbert,
> On Tue, Jun 14, 2016 at 03:20:06PM +0200, Stephan Mueller wrote:
> > memzero_explicit(raw_key) should be added here in success and failure code
> > paths.
>
> The raw_key is just a bunch of pointers, do we really need to
> zero it?
You are correct.
But then I need to refine my question: isn't rsa_parse_priv_key allocating the
MPIs (at least rsa_parse_priv_key seems to hint to that considering the error
code path)? So, shouldn't the MPIs be freed here with free_mpis()? This would
apply to parse_pub_key too.
Ciao
Stephan
next prev parent reply other threads:[~2016-06-14 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 13:14 [PATCH v5] crypto: rsa - return raw integers for the ASN.1 parser Tudor Ambarus
2016-06-14 13:20 ` Stephan Mueller
2016-06-14 13:38 ` Herbert Xu
2016-06-14 13:53 ` Stephan Mueller [this message]
2016-06-14 14:35 ` Tudor-Dan Ambarus
2016-06-15 9:28 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1920297.cMHx9vzUDS@tauon.atsec.com \
--to=smueller@chronox.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=tudor-dan.ambarus@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox