From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0996320D50C; Tue, 6 May 2025 06:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746514284; cv=none; b=A7i/KONPvaFX2s+bfDUBu0qPi8psffz31INea7tLwQz0i2xAbVYjYfHLF6wDCHLlFPFZ9IUWcB/NGK6kZgXF3ZSSvMLK02SoSB2EWgYGnD9COUlr5UZHhKPk8fSBN2ZTbzJSh2CEnJFwAutHV32k/DogMBUlUcDVdScLaDROPxQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746514284; c=relaxed/simple; bh=f6MCVMoyIyDh6X4+NpBMr+x9iT3qZ16UKn4vne88fnw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QuBFKwBqlhDbQQpZOortOpt8QIlHs7cpHe3qyZVItAeQS92o8mwmh9vwX12dsZ9mbDaLtfXiaOUp50XwR4JVVUbToq0MteETcoKj11tjA/fwAXmSe9QCeWq+idNT4LzteIms8ynL6Ccbe/yE6aybNwb6XgM4zWRkZsyBrFzWFQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RiC9h1cA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RiC9h1cA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D52DC4CEE4; Tue, 6 May 2025 06:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746514283; bh=f6MCVMoyIyDh6X4+NpBMr+x9iT3qZ16UKn4vne88fnw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RiC9h1cAhVOYw+f7nbJCESnvHsnlp/Zo8dlQQMrVi3QKsiK0fJ3WOv8PunT6DLvD9 AHH1eG81vleGwVN0GMyGOAtQjad7TQHMDmpLHAc/NCymGmWjWMYXxwezwX/Pm7G40/ 6UWSTsMqYkMFghfm1upKDDEH/J5yy6KIagRlzD20KK+xXXgBTkE5O68rIWv9mRE0bU 7nxHITvEb5GNQxctVq6CYliCQdnOe1zkcXzs0qbWk9d0fevdhRqMORVzTwy1Gm3fU9 6AftAREM5KqWn6gLNN66hx73rG4MQa52rNXsHbxz96YOw65ktlqqY2T9NuBd80kp7Z UTw6w+d2+SF0g== Message-ID: <19b1fca7-e1b1-4190-9bcb-7ce36fabd02e@kernel.org> Date: Tue, 6 May 2025 08:51:19 +0200 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] dt-bindings: crypto: Document support for SPAcc To: Pavitrakumar Managutte Cc: linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, herbert@gondor.apana.org.au, robh@kernel.org, Ruud.Derwig@synopsys.com, manjunath.hadli@vayavyalabs.com, adityak@vayavyalabs.com, Bhoomika Kadabi References: <20250505125538.2991314-1-pavitrakumarm@vayavyalabs.com> <20250505125538.2991314-2-pavitrakumarm@vayavyalabs.com> <5b6c66e8-3fac-408f-980c-f261ccd3fefd@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 06/05/2025 08:33, Pavitrakumar Managutte wrote: > Hi Krzysztof, > My comments are embedded below. > > Warm regards, > PK > > On Mon, May 5, 2025 at 9:22 PM Krzysztof Kozlowski wrote: >> >> On 05/05/2025 17:48, Krzysztof Kozlowski wrote: >>> On 05/05/2025 14:55, Pavitrakumar M wrote: >>>> From: Pavitrakumar Managutte >>>> >>>> Add DT bindings related to the SPAcc driver for Documentation. >>>> DWC Synopsys Security Protocol Accelerator(SPAcc) Hardware Crypto >>>> Engine is a crypto IP designed by Synopsys. >>>> >>>> Co-developed-by: Bhoomika Kadabi >>>> Signed-off-by: Bhoomika Kadabi >>>> Signed-off-by: Pavitrakumar Managutte >>>> Acked-by: Ruud Derwig >>> >>> >>> I do not see any improvements. It seems you ignored all comments, not >>> single one was responded to or addressed. > > PK: Addressed all the below > > 1. SoC Bindings: We dont have any SoC bindings since its tested on the > Zynq platform (on FPGA). So I have retained just the Synopsys SPAcc > device here. Also added a detailed description for the same, which > describes how we have tested the SPAcc peripheral on Zynq. This was > based on your inputs to describe the existing hardware. 1. I asked to use SoC specific compatibles and after such explanation that you use it in some different, hardware configuration, I asked to use that. Reflect whatever your hardware is called in the compatible. I claim this cannot be used in a SoC without customization. If I understood correctly this is soft IP in FPGA for evaluation, so no one will be ever able to use it. Therefore this binding makes no sense to me in general: you do not add anything any customer could use. It is fine to add something which you use internally only, but again describe the hardware properly. 2. I wrote you entire guide what is wrong with your Cc addresses and this was fully ignored. Neither responded to, nor resolved. I am not going to review the rest of the file. Best regards, Krzysztof