From: "Arnd Bergmann" <arnd@arndb.de>
To: "Herbert Xu" <herbert@gondor.apana.org.au>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Corentin Labbe" <clabbe.montjoie@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Eric Biggers" <ebiggers@kernel.org>,
"Ovidiu Panait" <ovidiu.panait.oss@gmail.com>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: sun8i-ss - avoid hash and rng references
Date: Thu, 23 Apr 2026 11:25:19 +0200 [thread overview]
Message-ID: <1cd6ddc3-479c-4cbf-8315-78bc53ac3a54@app.fastmail.com> (raw)
In-Reply-To: <aenfmxOvtHaAODqH@gondor.apana.org.au>
On Thu, Apr 23, 2026, at 11:00, Herbert Xu wrote:
> On Thu, Apr 23, 2026 at 08:55:42AM +0200, Arnd Bergmann wrote:
> Does this work?
>
> if (IS_ENABLED(CONFIG_CRYPTO_DEV_SUN4I_SS_PRNG))
> seq_printf(seq, "%s %s reqs=%lu tsize=%lu\n",
> ss_algs[i].alg.rng.base.cra_driver_name,
> ss_algs[i].alg.rng.base.cra_name,
> ss_algs[i].stat_req, ss_algs[i].stat_bytes);
> break;
Yes, I can rework the patch that way. I had considered this originally
but decided this would end up less readable in this case because
of the extra indentation level. The drivers already has a lot of
#ifdef checks, so adding more of those felt more in line with the
style used here.
Arnd
next prev parent reply other threads:[~2026-04-23 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 6:55 [PATCH] crypto: sun8i-ss - avoid hash and rng references Arnd Bergmann
2026-04-23 9:00 ` Herbert Xu
2026-04-23 9:25 ` Arnd Bergmann [this message]
2026-04-23 9:27 ` Herbert Xu
2026-04-23 10:26 ` Arnd Bergmann
2026-04-23 11:09 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cd6ddc3-479c-4cbf-8315-78bc53ac3a54@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=ovidiu.panait.oss@gmail.com \
--cc=samuel@sholland.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox