From: rsnel@cube.dyndns.org
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
Subject: Re: LRW implementation, please comment
Date: Fri, 1 Sep 2006 10:55:14 +0200 [thread overview]
Message-ID: <20060901085514.GA4821@cube.dyndns.org> (raw)
In-Reply-To: <20060901035225.GA9547@gondor.apana.org.au>
Hello,
On Fri, Sep 01, 2006 at 01:52:25PM +1000, Herbert Xu wrote:
> On Thu, Aug 31, 2006 at 02:39:30PM +0200, Rik Snel wrote:
> > This is an attempt at implementing LRW for the new blockcipher API.
> > Please review, test and comment.
>
> Thanks a lot for doing this. It looks good to me.
That's good to hear.
> There are a few style (see Documentation/CodingStyle) issues. It would
> be good if you can fix them up before I apply the patches.
Can you give some examples about what I missed from CodingStyle?
(I just reread it and I think my patch adheres pretty well to those
rules: tabs=8, K&R bracing, don't pollute global namespace etc...)
> Could you also convert the test vectors to use tcrypt.h/tcrypt.c?
Yes, I just didn't know what tcrypt.[ch] was for, otherwise I would have put
those vectors there in the first place. The last testvector, however,
won't fit because it is an entire 512 byte sector. (which is not that
bad, because alle narrow blocks (16 bytes) are encrypted independently,
no realistic testvector of a wide block cipher mode would fit. (ABL uses
blocks of any size, say 512 bytes, and if 1 bit changes in the plaintext
block, the whole cypher block will be affected) I will propose something
to fix that if ABL is finished.
Greetings,
Rik.
--
Nothing is ever a total loss; it can always serve as a bad example.
next prev parent reply other threads:[~2006-09-01 8:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 12:39 LRW implementation, please comment Rik Snel
2006-08-31 12:39 ` [PATCH 1/6] crypto: trivial comment improvements Rik Snel
2006-08-31 12:39 ` [PATCH 2/6] crypto: benbi IV, big endian narrow block count for LRW-32-AES Rik Snel
2006-08-31 12:39 ` [PATCH 3/6] crypto: some common 128-bit block operations, nicely centralized Rik Snel
2006-08-31 12:39 ` [PATCH 4/6] crypto: table driven multiplications in GF(2^128), needed by LRW (and in the future ABL) Rik Snel
2006-08-31 12:39 ` [PATCH 5/6] crypto: LRW, Liskov Rivest Wagner, a tweakable narrow block cipher mode Rik Snel
2006-08-31 12:39 ` [PATCH 6/6] crypto: a simple way of storing and checking test vectors, LRW vectors included Rik Snel
2006-09-01 3:52 ` LRW implementation, please comment Herbert Xu
2006-09-01 8:55 ` rsnel [this message]
2006-09-01 10:37 ` Herbert Xu
2006-09-02 1:00 ` LRW... v2 rsnel
2006-11-29 8:04 ` Herbert Xu
2006-09-02 1:00 ` [PATCHv2 1/6] crypto: trivial comment improvements rsnel
2006-09-02 1:00 ` [PATCHv2 2/6] crypto: benbi IV, big endian narrow block count for LRW-32-AES rsnel
2006-09-02 1:00 ` [PATCHv2 3/6] crypto: some common 128-bit block operations, nicely centralized rsnel
2006-09-02 1:00 ` [PATCHv2 4/6] crypto: table driven multiplications in GF(2^128), needed by LRW (and in the future ABL) rsnel
2006-11-26 23:56 ` Herbert Xu
2006-11-28 20:02 ` rsnel
2006-11-28 21:13 ` Herbert Xu
2006-11-28 21:17 ` rsnel
2006-11-28 22:24 ` Herbert Xu
2006-09-02 1:00 ` [PATCHv2 5/6] LRW, Liskov Rivest Wagner, a tweakable narrow block cipher mode rsnel
2006-09-02 1:00 ` [PATCHv2 6/6] LRW testvectors in tcrypt.[ch] rsnel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060901085514.GA4821@cube.dyndns.org \
--to=rsnel@cube.dyndns.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox