Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Hye-Shik Chang <perky@FreeBSD.org>
Cc: linux-crypto@vger.kernel.org
Subject: Re: PATCH: SEED cipher support
Date: Sun, 12 Aug 2007 19:31:53 +0400	[thread overview]
Message-ID: <20070812153152.GA3595@2ka.mipt.ru> (raw)
In-Reply-To: <20070812151130.GA37318@FreeBSD.org>

Hi.

On Mon, Aug 13, 2007 at 12:11:30AM +0900, Hye-Shik Chang (perky@FreeBSD.org) wrote:
> Hello,
> 
> Here I propose a patch for linux crypto API to add a support SEED
> (RFC4269).  This patch was generated against git-HEAD as of today.
> This patch have been used in few VPN appliance vendors in Korea for
> several years.  And it was verified by KISA, who developed the
> algorithm itself.
> 
> As its importance in Korean banking industry, it would be great
> if linux incorporates the support.

Besides the only c++ comment in the tcrypt.c this patch
looks really good. This is a good submission.
As a side note: please do not send gzipped patches, since it is quite
hard to show where the problem in the patch is if any when replying.

-- 
	Evgeniy Polyakov

  reply	other threads:[~2007-08-12 15:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-12 15:11 PATCH: SEED cipher support Hye-Shik Chang
2007-08-12 15:31 ` Evgeniy Polyakov [this message]
2007-08-17  3:24   ` Herbert Xu
2007-08-17  3:23 ` Herbert Xu
2007-08-21  6:29   ` Hye-Shik Chang
2007-08-21 12:59     ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070812153152.GA3595@2ka.mipt.ru \
    --to=johnpol@2ka.mipt.ru \
    --cc=linux-crypto@vger.kernel.org \
    --cc=perky@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox