Re: geode: fix not inplace encryption

["Jordan Crouse" <jordan.crouse@amd.com>]

On 06/11/07 21:01 +0100, Sebastian Siewior wrote:
> Currently the Geode AES module fails to encrypt or decrypt if
> the coherent bits are not set what is currently the case if the
> encryption does not occur inplace. However, the encryption works 
> on my Geode machine _only_ if the coherent bits are always set.
> 
> Cc: Jordan Crouse <jordan.crouse@amd.com>
> Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>

Acked-by: Jordan Crouse <jordan.crouse@amd.com>

Anything in the cache is suspect - turning on coherency is the best plan
to be rock solid.

> ---
>  drivers/crypto/geode-aes.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/geode-aes.c b/drivers/crypto/geode-aes.c
> index f2d4fba..0ca92d4 100644
> --- a/drivers/crypto/geode-aes.c
> +++ b/drivers/crypto/geode-aes.c
> @@ -81,8 +81,7 @@ geode_aes_crypt(struct geode_aes_op *op)
>  	 * we don't need to worry
>  	 */
>  
> -	if (op->src == op->dst)
> -		flags |= (AES_CTRL_DCA | AES_CTRL_SCA);
> +	flags |= (AES_CTRL_DCA | AES_CTRL_SCA);
>  
>  	if (op->dir == AES_DIR_ENCRYPT)
>  		flags |= AES_CTRL_ENCRYPT;
> -- 
> 1.5.3.4
> 
> 
> 

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.