From: Andi Kleen <andi@firstfloor.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: Andi Kleen <andi@firstfloor.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] [CRYPTO] cast6: inline bloat--
Date: Thu, 10 Jan 2008 10:25:55 +0100 [thread overview]
Message-ID: <20080110092555.GB25076@one.firstfloor.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0801101114070.1408@kivilampi-30.cs.helsinki.fi>
On Thu, Jan 10, 2008 at 11:17:10AM +0200, Ilpo Järvinen wrote:
> On Thu, 10 Jan 2008, Andi Kleen wrote:
>
> > "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi> writes:
> >
> > > Bloat-o-meter shows rather high readings for cast6...
> >
> > Have you measured if the performance doesn't suffer from that
> > change? Inner loops of ciphers tend to be quite performance
> > sensitive and the inlines might actually help a lot.
>
> No, I haven't measured.
Then I don't think the patch should have been applied.
-Andi
next prev parent reply other threads:[~2008-01-10 9:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 13:40 [PATCH] [CRYPTO] cast6: inline bloat-- Ilpo Järvinen
2008-01-08 6:33 ` Herbert Xu
2008-01-10 3:03 ` Andi Kleen
2008-01-10 9:17 ` Ilpo Järvinen
2008-01-10 9:25 ` Andi Kleen [this message]
2008-01-10 9:27 ` Herbert Xu
2008-01-10 9:44 ` Andi Kleen
2008-01-10 13:35 ` Sebastian Siewior
2008-01-10 15:46 ` Andi Kleen
2008-01-12 0:09 ` Sebastian Siewior
2008-01-12 0:57 ` Herbert Xu
2008-01-12 8:04 ` Sebastian Siewior
2008-01-12 2:47 ` Andi Kleen
2008-01-12 2:56 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080110092555.GB25076@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox