Re: HIFN+IPsec crashes in current -git

[Evgeniy Polyakov <johnpol@2ka.mipt.ru>]

On Thu, Feb 21, 2008 at 01:26:20AM +0800, Herbert Xu (herbert@gondor.apana.org.au) wrote:
> On Wed, Feb 20, 2008 at 01:33:22PM +0100, Patrick McHardy wrote:
> >
> > I saw the discrepancy between the elen value used
> > for aead_request_set_crypt() in esp_input() and the
> > req->nbytes value seen in hifn_setup_session().
> 
> OK that is normal.  esp_input is now using the AEAD interface
> so the size for the request includes the ICV.  By the time the
> request gets to hifn it no longer has the ICV so it would be
> 12 bytes elss.

But req->nbytes should or should not correspond to number of bytes to be
encrypted? HIFN driver assumes so, it can be changed to run through
scatterlists (btw, how will it determine how many of them were
provided?) and get full size of the request from them, but I suspected
that req->nbytes should always be equal to number of bytes to be
encrypted by the driver, otherwise where to get that info from?

-- 
	Evgeniy Polyakov