From: Sebastian Siewior <linux-crypto@ml.breakpoint.cc>
To: Jan Glauber <jang@linux.vnet.ibm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 1/4] generic sha_update and sha_final for s390
Date: Mon, 3 Mar 2008 23:05:24 +0100 [thread overview]
Message-ID: <20080303220524.GA30074@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <1204561183.6025.51.camel@localhost.localdomain>
* Jan Glauber | 2008-03-03 17:19:43 [+0100]:
>Index: cryptodev-2.6/arch/s390/crypto/Makefile
>===================================================================
>--- cryptodev-2.6.orig/arch/s390/crypto/Makefile
>+++ cryptodev-2.6/arch/s390/crypto/Makefile
>@@ -2,8 +2,8 @@
> # Cryptographic API
> #
>
>-obj-$(CONFIG_CRYPTO_SHA1_S390) += sha1_s390.o
>-obj-$(CONFIG_CRYPTO_SHA256_S390) += sha256_s390.o
>+obj-$(CONFIG_CRYPTO_SHA1_S390) += sha1_s390.o sha_common.o
>+obj-$(CONFIG_CRYPTO_SHA256_S390) += sha256_s390.o sha_common.o
So this is a little trick to avoid select in Kconfig? nice :)
> obj-$(CONFIG_CRYPTO_DES_S390) += des_s390.o des_check_key.o
> obj-$(CONFIG_CRYPTO_AES_S390) += aes_s390.o
> obj-$(CONFIG_S390_PRNG) += prng.o
>Index: cryptodev-2.6/arch/s390/crypto/sha.h
>===================================================================
>--- /dev/null
>+++ cryptodev-2.6/arch/s390/crypto/sha.h
>@@ -0,0 +1,34 @@
>+/*
>+ * Cryptographic API.
>+ *
>+ * s390 generic implementation of the SHA Secure Hash Algorithms.
>+ *
>+ * Copyright IBM Corp. 2007
Just a nitpick: shouldn't this be the year you wrote the code? I really
don't know.
Sebastian
next prev parent reply other threads:[~2008-03-03 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 16:19 [PATCH 1/4] generic sha_update and sha_final for s390 Jan Glauber
2008-03-03 22:05 ` Sebastian Siewior [this message]
2008-03-04 10:26 ` Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303220524.GA30074@Chamillionaire.breakpoint.cc \
--to=linux-crypto@ml.breakpoint.cc \
--cc=herbert@gondor.apana.org.au \
--cc=jang@linux.vnet.ibm.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox