回复：Re: vgdisplay problem with hifn795x

回复：Re: vgdisplay problem with hifn795x

[tanglb]

Hi,

I downloaded the source file from your link and compiled successfully.
But it still hang when I tried to run "mkfs.xfs".

The hifn card is Express DS 100, Part Number is:7956HXL-PCIU.
Please let me know if you need further information.
Thank you!

Regards,
Lingbo

----- 原始邮件 -----
发件人：Evgeniy Polyakov 
收件人：tanglb@sina.com
主题：Re: vgdisplay problem with hifn795x
日期：2008-11-29 22:25:14

Hi.

On Sat, Nov 29, 2008 at 08:46:28PM +0800, tanglb@sina.com (tanglb@sina.com) wrote:
> I'm testing one hifn card with cryptsetup, but the vgdisplay will hang after I created the LV
> by cryptsetup. If I reboot the system, the system will hang during activating LVs at boot time.
> 
> The system is CentOS5.2+2.6.27.4 kernel. I used all default options to create the encryption disk.

I do not know what is vgdisplay, but HIFN driver got several bug fixes
recently, so if problem is related to the driver, likely it was fixed.
You may try pulling driver from the cryptodev repo [1] into your kernel
build system and compile it, or wait for the kernel update from your
vendor. Likely this bugfixes will be pushed into mainline tree in 2.6.29
merge window.

1. cryptodev tree
http://git.kernel.org/?p=linux/kernel/git/herbert/cryptodev-2.6.git

-- 
Evgeniy Polyakov


-------------------------------------------------------------------
新浪空间——与朋友开心分享网络新生活！(http://space.sina.com.cn/ )

Re: 回复：Re: vgdisplay problem with hifn795x

[Evgeniy Polyakov]

On Sun, Nov 30, 2008 at 04:26:00PM +0800, tanglb@sina.com (tanglb@sina.com) wrote:
> I downloaded the source file from your link and compiled successfully.
> But it still hang when I tried to run "mkfs.xfs".

Please enable debug mode with attached patch and send dmesg output.
Thank you.

diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index 6e9b39c..ca621f6 100644
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -38,7 +38,7 @@
 
 #include <asm/kmap_types.h>
 
-//#define HIFN_DEBUG
+#define HIFN_DEBUG
 
 #ifdef HIFN_DEBUG
 #define dprintk(f, a...) 	printk(f, ##a)

-- 
	Evgeniy Polyakov

Re: 回复：Re: vgdisplay problem with hifn795x

[Lingbo Tang (SINA)]

Evgeniy Polyakov wrote:
> On Sun, Nov 30, 2008 at 04:26:00PM +0800, tanglb@sina.com (tanglb@sina.com) wrote:
>> I downloaded the source file from your link and compiled successfully.
>> But it still hang when I tried to run "mkfs.xfs".
> 
> Please enable debug mode with attached patch and send dmesg output.
> Thank you.

The weird thing is that there is no problem if I turned on the debug
option. I can see kcryptd taking 99% CPU time and there are many
debug output from the serial port, but the encrypted LVM worked eventually.

In some cases the non-debug version can work with "mkfs.xfs", but it
could not in most case.
I tried to disable most services in the system, but it seems have no
related to the system load.

> 
> diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
> index 6e9b39c..ca621f6 100644
> --- a/drivers/crypto/hifn_795x.c
> +++ b/drivers/crypto/hifn_795x.c
> @@ -38,7 +38,7 @@
>  
>  #include <asm/kmap_types.h>
>  
> -//#define HIFN_DEBUG
> +#define HIFN_DEBUG
>  
>  #ifdef HIFN_DEBUG
>  #define dprintk(f, a...) 	printk(f, ##a)
> 

Re: 回复：Re: vgdisplay problem with hifn795x

[Evgeniy Polyakov]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

On Sat, Dec 06, 2008 at 10:09:55PM +0800, Lingbo Tang (SINA) (tanglb@sina.com) wrote:
> In some cases the non-debug version can work with "mkfs.xfs", but it
> could not in most case.
> I tried to disable most services in the system, but it seems have no
> related to the system load.

So I suppose it is easy to reproduce problem. Please show 'dmesg' output
for the hung case when debug is turned off. Did you see register dump
message when that happened? Please also try attached patch and show the
hung dmesg (with tured off heavy debug).

Thank you.

-- 
	Evgeniy Polyakov

[-- Attachment #2: hifn.err_debug --]
[-- Type: text/plain, Size: 458 bytes --]

diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index 6e9b39c..fc29bec 100644
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -2093,6 +2093,10 @@ static int hifn_handle_req(struct ablkcipher_request *req)
 		spin_unlock_irqrestore(&dev->lock, flags);
 	}
 
+	if (err)
+		printk("%s: nbytes: %u, started: %u, qlen: %d, err: %d.\n",
+			__func__, req->nbytes, dev->started, dev->queue.qlen, err);
+
 	return err;
 }
 

Re: 回复：Re: vgdisplay problem with hifn795x

[Lingbo Tang (SINA)]

Evgeniy Polyakov wrote:
> On Sat, Dec 06, 2008 at 10:09:55PM +0800, Lingbo Tang (SINA) (tanglb@sina.com) wrote:
>> In some cases the non-debug version can work with "mkfs.xfs", but it
>> could not in most case.
>> I tried to disable most services in the system, but it seems have no
>> related to the system load.
> 
> So I suppose it is easy to reproduce problem. Please show 'dmesg' output
> for the hung case when debug is turned off. Did you see register dump
> message when that happened? Please also try attached patch and show the
> hung dmesg (with tured off heavy debug).
> 

There is no message when my system hung with debug disabled.

After I patched your new code, there is no hang anymore. I got following 
message:

Dec  7 18:06:15 localhost kernel: hifn_handle_req: nbytes: 512, started: 
23, qlen: 1, err: -115.
Dec  7 18:06:16 localhost last message repeated 87 times
Dec  7 18:06:16 localhost kernel: hifn_handle_req: nbytes: 512, started: 
23, qlen: 0, err: -115.
Dec  7 18:06:16 localhost kernel: hifn_handle_req: nbytes: 512, started: 
23, qlen: 1, err: -115.
Dec  7 18:06:18 localhost last message repeated 344 times
Dec  7 18:06:18 localhost kernel: Filesystem "dm-3": Disabling barriers, 
trial barrier write failed
Dec  7 18:06:18 localhost kernel: XFS mounting filesystem dm-3
Dec  7 18:06:19 localhost kernel: hifn_handle_req: nbytes: 512, started: 
23, qlen: 1, err: -115.
Dec  7 18:06:19 localhost last message repeated 21 times
Dec  7 18:06:19 localhost kernel: XFS quotacheck dm-3: Please wait.
Dec  7 18:06:19 localhost kernel: XFS quotacheck dm-3: Done.
Dec  7 18:06:19 localhost kernel: hifn_handle_req: nbytes: 512, started: 
23, qlen: 1, err: -115.
Dec  7 18:06:19 localhost last message repeated 2 times
Dec  7 18:06:25 localhost ntpd[2125]: synchronized to LOCAL(0), stratum 10
Dec  7 18:06:25 localhost ntpd[2125]: kernel time sync enabled 0001
Dec  7 18:06:35 localhost kernel: hifn_handle_req: nbytes: 512, started: 
23, qlen: 0, err: -115.
Dec  7 18:06:35 localhost kernel: hifn_handle_req: nbytes: 512, started: 
23, qlen: 1, err: -115.

Regards,
Lingbo