Re: [PATCH 1/2 v4] crypto: sha512 - Move message schedule W[80] to static percpu area

[Evgeniy Polyakov <zbr@ioremap.net>]

Hi.

On Sun, Dec 07, 2008 at 11:17:28PM +0100, Adrian-Ken Rueegsegger (ken@codelabs.ch) wrote:
> The message schedule W (u64[80]) is too big for the stack. In order
> for this algorithm to be used with shash it is moved to a static
> percpu area.
> 
> Signed-off-by: Adrian-Ken Rueegsegger <ken@codelabs.ch>



> +static DEFINE_PER_CPU(u64[80], msg_schedule);
> +
>  static inline u64 Ch(u64 x, u64 y, u64 z)
>  {
>          return z ^ (x & (y ^ z));
> @@ -89,11 +90,12 @@ static inline void BLEND_OP(int I, u64 *W)
>  }
>  
>  static void
> -sha512_transform(u64 *state, u64 *W, const u8 *input)
> +sha512_transform(u64 *state, const u8 *input)
>  {
>  	u64 a, b, c, d, e, f, g, h, t1, t2;
>  
>  	int i;
> +	u64 *W = get_cpu_var(msg_schedule);

This should be protected by preempt_disable(), shouldn't it?

-- 
	Evgeniy Polyakov