From: Sebastian Andrzej Siewior <linux-crypto@ml.breakpoint.cc>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
davem@davemloft.net,
Eric Sesterhenn <eric.sesterhenn@lsexperts.de>
Subject: Re: Bug when modprobing tcrypt
Date: Mon, 29 Jun 2009 16:07:04 +0200 [thread overview]
Message-ID: <20090629140704.GA25939@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <1246281425.3688.13.camel@queen>
* Eric Sesterhenn | 2009-06-29 15:17:05 [+0200]:
>[ 122.967099] BUG: sleeping function called from invalid context at
>kernel/rwsem.c:21
>[ 122.967398] in_atomic(): 1, irqs_disabled(): 0, pid: 4926, name:
>modprobe
>[ 122.967643] INFO: lockdep is turned off.
>[ 122.967858] Pid: 4926, comm: modprobe Tainted: G M
>2.6.31-rc1-22297-g5298976 #24
>[ 122.968176] Call Trace:
>[ 122.968411] [<c011dd93>] __might_sleep+0xf9/0x101
>[ 122.968677] [<c0777aa0>] down_read+0x16/0x68
>[ 122.968928] [<c048bf04>] crypto_alg_lookup+0x16/0x34
>[ 122.969479] [<c048bf52>] crypto_larval_lookup+0x30/0xf9
>[ 122.969722] [<c048c038>] crypto_alg_mod_lookup+0x1d/0x62
>[ 122.969977] [<c048c13e>] crypto_alloc_base+0x1e/0x64
>[ 122.970271] [<c04bf991>] reset_prng_context+0xab/0x13f
>[ 122.970523] [<c04e5cfc>] ? __spin_lock_init+0x27/0x51
>[ 122.970777] [<c04bfce1>] cprng_init+0x2a/0x42
>[ 122.971012] [<c048bb4c>] __crypto_alloc_tfm+0xfa/0x128
>[ 122.971304] [<c048c153>] crypto_alloc_base+0x33/0x64
>[ 122.971556] [<c04933c9>] alg_test_cprng+0x30/0x1f4
>[ 122.971809] [<c0493329>] alg_test+0x12f/0x19f
>[ 122.972103] [<c0177f1f>] ? __alloc_pages_nodemask+0x14d/0x481
>[ 122.972356] [<d09219e2>] do_test+0xf9d/0x163f [tcrypt]
>[ 122.972613] [<d0920de6>] do_test+0x3a1/0x163f [tcrypt]
>[ 122.972855] [<d0926035>] tcrypt_mod_init+0x35/0x7c [tcrypt]
>[ 122.973488] [<c010113c>] _stext+0x54/0x12c
>[ 122.974575] [<d0926000>] ? tcrypt_mod_init+0x0/0x7c [tcrypt]
>[ 122.974836] [<c01398a3>] ? up_read+0x16/0x2b
>[ 122.975126] [<c0139fc4>] ? __blocking_notifier_call_chain+0x40/0x4c
>[ 122.975376] [<c014ee8d>] sys_init_module+0xa9/0x1bf
>[ 122.975635] [<c010292b>] sysenter_do_call+0x12/0x32
reset_prng_context() grabs a spinlock. That prng_lock spinlock is taken
with irqsave and sometimes without what does not look good on the first
look.
Neil: It is legal for crypto_alloc_cipher() because it might load
another module. Are you fine with the replacement of the spinlock with a
mutex? rngapi_reset() in crypto/rng.c does kmalloc() with GFP_KERNEL so
it looks like it is okay to sleep there.
Sebastian
next prev parent reply other threads:[~2009-06-29 14:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 13:17 Bug when modprobing tcrypt Eric Sesterhenn
2009-06-29 14:07 ` Sebastian Andrzej Siewior [this message]
2009-06-29 15:20 ` Neil Horman
2009-06-29 21:44 ` [PATCH 1/2] crypto/ansi prng: use just a BH lock Sebastian Andrzej Siewior
2009-06-30 14:14 ` Neil Horman
2009-06-29 21:45 ` [PATCH 2/2] crypto/ansi prng: alloc cipher just in in init() Sebastian Andrzej Siewior
2009-06-29 21:48 ` Sebastian Andrzej Siewior
2009-06-29 21:54 ` Neil Horman
2009-06-30 14:51 ` Neil Horman
2009-06-30 19:55 ` [PATCH v2] " Sebastian Andrzej Siewior
2009-07-01 0:06 ` Neil Horman
[not found] ` <20090701072517.GA9583@Chamillionaire.breakpoint.cc>
2009-07-01 10:36 ` Neil Horman
2009-07-03 4:11 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090629140704.GA25939@Chamillionaire.breakpoint.cc \
--to=linux-crypto@ml.breakpoint.cc \
--cc=davem@davemloft.net \
--cc=eric.sesterhenn@lsexperts.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox