From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH v2] crypto/ansi prng: alloc cipher just in in init() Date: Tue, 30 Jun 2009 20:06:48 -0400 Message-ID: <20090701000648.GA12326@localhost.localdomain> References: <1246281425.3688.13.camel@queen> <20090629140704.GA25939@Chamillionaire.breakpoint.cc> <20090629152027.GA5022@hmsreliant.think-freely.org> <20090629214508.GB29616@Chamillionaire.breakpoint.cc> <20090630145150.GB13116@hmsreliant.think-freely.org> <20090630195517.GA4659@Chamillionaire.breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, davem@davemloft.net, Eric Sesterhenn To: Sebastian Andrzej Siewior Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:56576 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbZGAAGy (ORCPT ); Tue, 30 Jun 2009 20:06:54 -0400 Content-Disposition: inline In-Reply-To: <20090630195517.GA4659@Chamillionaire.breakpoint.cc> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, Jun 30, 2009 at 09:55:18PM +0200, Sebastian Andrzej Siewior wrote: > As reported by Eric Sesterhenn the re-allocation of the cipher in reset leads > to: > |BUG: sleeping function called from invalid context at kernel/rwsem.c:21 > |in_atomic(): 1, irqs_disabled(): 0, pid: 4926, name: modprobe > |INFO: lockdep is turned off. > |Pid: 4926, comm: modprobe Tainted: G M 2.6.31-rc1-22297-g5298976 #24 > |Call Trace: > | [] __might_sleep+0xf9/0x101 > | [] down_read+0x16/0x68 > | [] crypto_alg_lookup+0x16/0x34 > | [] crypto_larval_lookup+0x30/0xf9 > | [] crypto_alg_mod_lookup+0x1d/0x62 > | [] crypto_alloc_base+0x1e/0x64 > | [] reset_prng_context+0xab/0x13f > | [] ? __spin_lock_init+0x27/0x51 > | [] cprng_init+0x2a/0x42 > | [] __crypto_alloc_tfm+0xfa/0x128 > | [] crypto_alloc_base+0x33/0x64 > | [] alg_test_cprng+0x30/0x1f4 > | [] alg_test+0x12f/0x19f > | [] ? __alloc_pages_nodemask+0x14d/0x481 > | [] do_test+0xf9d/0x163f [tcrypt] > | [] do_test+0x3a1/0x163f [tcrypt] > | [] tcrypt_mod_init+0x35/0x7c [tcrypt] > | [] _stext+0x54/0x12c > | [] ? tcrypt_mod_init+0x0/0x7c [tcrypt] > | [] ? up_read+0x16/0x2b > | [] ? __blocking_notifier_call_chain+0x40/0x4c > | [] sys_init_module+0xa9/0x1bf > | [] sysenter_do_call+0x12/0x32 > > because a spin lock is held and crypto_alloc_base() may sleep. > There is no reason to re-allocate the cipher, the state is resetted in > ->setkey(). This patches makes the cipher allocation a one time thing and > moves it to init. > > Reported-by: Eric Sesterhenn > Signed-off-by: Sebastian Andrzej Siewior I think this looks better, yeah, have you tested this? If not, give it a quick run please, and I'll ack it. Neil >