From: Andi Kleen <andi@firstfloor.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Roel Kluin <roel.kluin@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Mikael Pettersson <mikpe@it.uu.se>,
penberg@cs.helsinki.fi, Brian Gerst <brgerst@gmail.com>,
andi@firstfloor.org, Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, Herbert@gondor.apana.org.au
Subject: Re: [PATCH v1] compiler: prevent dead store elimination
Date: Mon, 1 Mar 2010 23:27:16 +0100 [thread overview]
Message-ID: <20100301222716.GC29531@one.firstfloor.org> (raw)
In-Reply-To: <20100228211511.60981829@infradead.org>
On Sun, Feb 28, 2010 at 09:15:11PM -0800, Arjan van de Ven wrote:
> On Sat, 27 Feb 2010 21:47:42 +0100
> Roel Kluin <roel.kluin@gmail.com> wrote:
> > +void secure_bzero(void *p, size_t n)
> > +{
> > + memset(p, 0, n);
> > + ARRAY_PREVENT_DSE(p, n);
> > +}
> > +EXPORT_SYMBOL(secure_bzero);
>
>
> please don't introduce bzero again to the kernel;
>
> make it secure_memset() please.
Would there ever be any reason to set the key to something
else than 0?
IMHO bzero is less error prone. With memset there are regular
bugs when the two end arguments get exchanged.
You could call it differently if you have a problem with old BSD
names, but inherently there's nothing wrong with them. One possibility
would be the same name as VC++ uses.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2010-03-01 22:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 20:47 [PATCH v1] compiler: prevent dead store elimination Roel Kluin
2010-02-28 9:55 ` Andi Kleen
2010-02-28 15:34 ` [PATCH v2] " Roel Kluin
2010-03-01 9:29 ` Mikael Pettersson
2010-03-02 12:17 ` Andi Kleen
2010-03-03 23:16 ` [PATCH v3] " Roel Kluin
2010-03-02 12:24 ` [PATCH v2] " Andi Kleen
2010-03-01 0:36 ` [PATCH v1] " Bill Davidsen
2010-03-01 5:15 ` Arjan van de Ven
2010-03-01 9:32 ` Mikael Pettersson
2010-03-01 9:33 ` Alexey Dobriyan
2010-03-01 22:27 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100301222716.GC29531@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=Herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=brgerst@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=penberg@cs.helsinki.fi \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).