From: Steffen Klassert <steffen.klassert@secunet.com>
To: Dan Carpenter <error27@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kern
Subject: Re: [patch] pcrypt: handle crypto_get_attr_type() errors
Date: Mon, 22 Mar 2010 14:23:42 +0100 [thread overview]
Message-ID: <20100322132342.GJ20508@secunet.com> (raw)
In-Reply-To: <20100321092847.GJ5331@bicker>
On Sun, Mar 21, 2010 at 12:28:47PM +0300, Dan Carpenter wrote:
> crypto_get_attr_type() can returns ERR_PTRs if there is a problem.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c
> index 8020124..41bd80f 100644
> --- a/crypto/pcrypt.c
> +++ b/crypto/pcrypt.c
> @@ -322,6 +322,8 @@ static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb)
> struct crypto_attr_type *algt;
>
> algt = crypto_get_attr_type(tb);
> + if (IS_ERR(algt))
> + return ERR_CAST(algt);
>
> alg = crypto_get_attr_alg(tb, algt->type,
> (algt->mask & CRYPTO_ALG_TYPE_MASK));
I've just noticed that we are calling crypto_get_attr_type already in
pcrypt_alloc, so perhaps we could just pass the type and mask to
pcrypt_alloc_aead. Then we can remove this second call to
crypto_get_attr_type completely.
Steffen
next prev parent reply other threads:[~2010-03-22 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 9:28 [patch] pcrypt: handle crypto_get_attr_type() errors Dan Carpenter
2010-03-22 13:23 ` Steffen Klassert [this message]
2010-03-22 13:48 ` Dan Carpenter
2010-03-22 13:53 ` [patch v2] " Dan Carpenter
2010-03-22 14:53 ` Steffen Klassert
2010-03-22 15:28 ` [patch v3] " Dan Carpenter
2010-03-23 10:34 ` Steffen Klassert
2010-03-24 13:35 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322132342.GJ20508@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).