From: Kim Phillips <kim.phillips@freescale.com>
To: Lee Nipper <lee.nipper@gmail.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: talitos - fix bug in sg_copy_end_to_buffer
Date: Mon, 12 Jul 2010 19:22:00 -0500 [thread overview]
Message-ID: <20100712192200.b5f6003a.kim.phillips@freescale.com> (raw)
In-Reply-To: <1278879846-29701-1-git-send-email-lee.nipper@gmail.com>
On Sun, 11 Jul 2010 15:24:06 -0500
Lee Nipper <lee.nipper@gmail.com> wrote:
> In function sg_copy_end_to_buffer, too much data
> is copied when a segment in the scatterlist
> has .length greater than the requested copy length.
>
> This patch adds the limit checks to fix this bug of over copying,
> which affected only the ahash algorithms.
>
> Signed-off-by: Lee Nipper <lee.nipper@gmail.com>
> ---
> Kim, this corrects the problem causing exceptions
> for tcrypt tests 402, 403, and 404.
> With this patch the tcrypt tests run through ok.
Ack, but..
> + if ((boffset + len) > buflen)
inner parens aren't necessary.
Kim
prev parent reply other threads:[~2010-07-13 0:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 20:24 [PATCH] crypto: talitos - fix bug in sg_copy_end_to_buffer Lee Nipper
2010-07-13 0:22 ` Kim Phillips [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712192200.b5f6003a.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=lee.nipper@gmail.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox