From: Greg KH <gregkh@suse.de>
To: Atul Sowani <sowani@gmail.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 2.6.37.2 1/1] crypto: Uninitialized variable fix.
Date: Fri, 25 Feb 2011 10:09:55 -0800 [thread overview]
Message-ID: <20110225180955.GA22156@suse.de> (raw)
In-Reply-To: <4D67EDC4.3020103@gmail.com>
On Fri, Feb 25, 2011 at 11:28:28PM +0530, Atul Sowani wrote:
> Array inter[4] was uninitialized in anubis_crypt() and was causing
> compiler warning. Added the array initialization.
>
> Signed-off-by: Atul Sowani <sowani@gmail.com>
> ---
>
> diff a/crypto/anubis.c b/crypto/anubis.c
> --- a/crypto/anubis.c 2011-02-25 04:39:00.000000000 +0530
> +++ b/crypto/anubis.c 2011-02-25 23:07:12.000000000 +0530
> @@ -578,7 +578,7 @@ static void anubis_crypt(u32 roundKey[AN
> __be32 *dst = (__be32 *)ciphertext;
> int i, r;
> u32 state[4];
> - u32 inter[4];
> + u32 inter[4] = { 0, 0, 0, 0 };
That's nice, it looks like a bug in the compiler, preinitializing this
variable doesn't fix any real bug.
sorry,
greg k-h
prev parent reply other threads:[~2011-02-25 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 17:58 [PATCH 2.6.37.2 1/1] crypto: Uninitialized variable fix Atul Sowani
2011-02-25 18:09 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110225180955.GA22156@suse.de \
--to=gregkh@suse.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=sowani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox