Re: aead: driver side documentation

[Kim Phillips <kim.phillips@freescale.com>]

On Fri, 8 Apr 2011 08:55:33 +0800
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> Kim Phillips <kim.phillips@freescale.com> wrote:
> >
> > I started to add test vectors from [1] to crypto/testmgr.c, but it
> > required that drivers not assume associated data, iv, and cipher data
> > were contiguous in memory, and since some of them do, I don't know if
> > such a contribution would be acceptable upstream.
> 
> Such drivers are broken and should be fixed.

ok.

> > then there's the rtnetlink dependencies I mention in [2] that
> > also make drivers fail AEAD testmgr tests in their setkey()
> > implementations, IIRC, because testmgr keys aren't RTA_OK.
> 
> Can you elaborate on this problem?

the following conditions in a driver setkey fail:

        if (!RTA_OK(rta, keylen))
                goto badkey;

        if (rta->rta_type != CRYPTO_AUTHENC_KEYA_PARAM)
                goto badkey;

because testmgr keys are plain strings, not rtattr structs.

Kim