From: Kim Phillips <kim.phillips@freescale.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <linux-crypto@vger.kernel.org>, Kumar Gala <kumar.gala@freescale.com>
Subject: Re: [PATCH] crypto: caam - fix operator precedence in shared descriptor allocation
Date: Wed, 29 Jun 2011 11:12:26 -0500 [thread overview]
Message-ID: <20110629111226.0ffca866.kim.phillips@freescale.com> (raw)
In-Reply-To: <20110526033044.GB14500@gondor.apana.org.au>
On Thu, 26 May 2011 13:30:44 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Mon, May 23, 2011 at 06:45:23PM -0500, Kim Phillips wrote:
> > setkey allocates 16 bytes (CAAM_CMD_SZ *
> > DESC_AEAD_SHARED_TEXT_LEN) shy of what is needed to
> > store the shared descriptor, resulting in memory
> > corruption. Fix this.
> >
> > Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
>
> Applied to cryptodev. Thanks Kim!
Herbert, this patch fixes a memory corruption bug introduced in
commit 4427b1b - "crypto: caam - add support for sha512 variants of
existing AEAD algorithms", which is currently the last commit for
caam in Linus' tree. Can you please push this commit (c5bf900 in
cryptodev) to Linus before he releases 3.0?
btw, it would be good if commit af56dea "crypto: caam - fix build
warning when DEBUG_FS not configured" were also pushed to avoid the
build-bot messages, but it's not nearly as important as this one.
Thanks,
Kim
next prev parent reply other threads:[~2011-06-29 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 23:45 [PATCH] crypto: caam - fix operator precedence in shared descriptor allocation Kim Phillips
2011-05-26 3:30 ` Herbert Xu
2011-06-29 16:12 ` Kim Phillips [this message]
2011-06-29 23:44 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110629111226.0ffca866.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=herbert@gondor.apana.org.au \
--cc=kumar.gala@freescale.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox