Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

[Josh Boyer <jwboyer@redhat.com>]

On Fri, Aug 19, 2011 at 04:12:08PM +0800, Herbert Xu wrote:
> On Fri, Aug 19, 2011 at 03:32:24PM +0800, Herbert Xu wrote:
> > 
> > Meanwhile I'll make a patch that ensures cryptd is registered
> > before aesni.
> 
> Please try this patch.  Thanks!

This worked great.  I'm confused why adding ivsize to the ablk_ecb_alg
"worked" as well, but looking at the traces again I agree this seems
like the actual problem.

Thanks!

> commit 9d4c522a113f6caa8b792ae829a25490fa87b1a2
> Author: Herbert Xu <herbert@gondor.apana.org.au>
> Date:   Fri Aug 19 16:11:23 2011 +0800
> 
>     crypto: cryptd - Use subsys_initcall to prevent races with aesni
>     
>     As cryptd is depeneded on by other algorithms such as aesni-intel,
>     it needs to be registered before them.  When everything is built
>     as modules, this occurs naturally.  However, for this to work when
>     they are built-in, we need to use subsys_initcall in cryptd.
>     
>     Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Tested-by: Josh Boyer <jwboyer@redhat.com>

> diff --git a/crypto/cryptd.c b/crypto/cryptd.c
> index e46d21a..671d4d6 100644
> --- a/crypto/cryptd.c
> +++ b/crypto/cryptd.c
> @@ -945,7 +945,7 @@ static void __exit cryptd_exit(void)
>  	crypto_unregister_template(&cryptd_tmpl);
>  }
>  
> -module_init(cryptd_init);
> +subsys_initcall(cryptd_init);
>  module_exit(cryptd_exit);
>  
>  MODULE_LICENSE("GPL");
> -- 
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt