From: msb@google.com
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Herbert Xu <herbert@gondor.hengli.com.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] lib/sha1.c: quite sparse noise about symbol not declared
Date: Tue, 13 Sep 2011 14:58:51 -0700 [thread overview]
Message-ID: <20110913215851.GD9560@google.com> (raw)
In-Reply-To: <201109091130.28110.hartleys@visionengravers.com>
+cc linux-crypto, herbert, davem, torvalds
H Hartley Sweeten (hartleys@visionengravers.com) wrote:
> Include <linux/cryptohash.h> to pickup the declarations for sha_transform
> and sha_init to quite the sparse noise:
>
> warning: symbol 'sha_transform' was not declared. Should it be static?
> warning: symbol 'sha_init' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Mandeep Singh Baines <msb@chromium.org>
>
Acked-by: Mandeep Singh Baines <msb@chromium.org>
Thanks.
> ---
>
> diff --git a/lib/sha1.c b/lib/sha1.c
> index f33271d..1de509a 100644
> --- a/lib/sha1.c
> +++ b/lib/sha1.c
> @@ -8,6 +8,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/bitops.h>
> +#include <linux/cryptohash.h>
> #include <asm/unaligned.h>
>
> /*
next parent reply other threads:[~2011-09-13 21:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201109091130.28110.hartleys@visionengravers.com>
2011-09-13 21:58 ` msb [this message]
2011-09-22 11:33 ` [PATCH] lib/sha1.c: quite sparse noise about symbol not declared Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913215851.GD9560@google.com \
--to=msb@google.com \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).