Re: [PATCH 6/7] crypto: serpent: add 8-way parallel x86_64/SSE2 assembler implementation

[Herbert Xu <herbert@gondor.apana.org.au>]

On Tue, Oct 18, 2011 at 12:03:18AM +0300, Jussi Kivilinna wrote:
> Patch adds x86_64/SSE2 assembler implementation of serpent cipher. Assembler
> functions crypt data in eigth block chunks (two 4 block chunk SSE2 operations
> in parallel to improve performance on out-of-order CPUs). Glue code is based
> on one from AES-NI implementation, so requests from irq context are redirected
> to cryptd.

This doesn't build for me:

  CC [M]  arch/x86/crypto/serpent_sse2_glue.o
arch/x86/crypto/serpent_sse2_glue.c:154: error: ‘THIS_MODULE’ undeclared here (not in a function)
arch/x86/crypto/serpent_sse2_glue.c:716: error: expected declaration specifiers or ‘...’ before string constant
arch/x86/crypto/serpent_sse2_glue.c:716: warning: data definition has no type or storage class
arch/x86/crypto/serpent_sse2_glue.c:716: warning: type defaults to ‘int’ in declaration of ‘MODULE_DESCRIPTION’
arch/x86/crypto/serpent_sse2_glue.c:716: warning: function declaration isn’t a prototype
arch/x86/crypto/serpent_sse2_glue.c:717: error: expected declaration specifiers or ‘...’ before string constant
arch/x86/crypto/serpent_sse2_glue.c:717: warning: data definition has no type or storage class
arch/x86/crypto/serpent_sse2_glue.c:717: warning: type defaults to ‘int’ in declaration of ‘MODULE_LICENSE’
arch/x86/crypto/serpent_sse2_glue.c:717: warning: function declaration isn’t a prototype
arch/x86/crypto/serpent_sse2_glue.c:718: error: expected declaration specifiers or ‘...’ before string constant
arch/x86/crypto/serpent_sse2_glue.c:718: warning: data definition has no type or storage class
arch/x86/crypto/serpent_sse2_glue.c:718: warning: type defaults to ‘int’ in declaration of ‘MODULE_ALIAS’
arch/x86/crypto/serpent_sse2_glue.c:718: warning: function declaration isn’t a prototype
make[2]: *** [arch/x86/crypto/serpent_sse2_glue.o] Error 1
make[1]: *** [arch/x86/crypto] Error 2
make: *** [arch/x86] Error 2

So I've applied patches 1-5, please resubmit 6-7 after you've
fixed them up.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt