From: Arnd Bergmann <arnd@arndb.de>
To: Andreas Westin <andreas.westin@stericsson.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, sfr@canb.auug.org.au,
lee.jones@linaro.org
Subject: Re: [PATCH 1/2] mach-ux500: Crypto: core support for CRYP/HASH module.
Date: Tue, 8 May 2012 19:37:24 +0000 [thread overview]
Message-ID: <201205081937.24450.arnd@arndb.de> (raw)
In-Reply-To: <1336476513-17145-2-git-send-email-andreas.westin@stericsson.com>
On Tuesday 08 May 2012, Andreas Westin wrote:
> This adds the required platform data and calls to enable
> the CRYP/HASH driver.
>
> index 15a0f63..a69db46 100644
> --- a/arch/arm/mach-ux500/id.c
> +++ b/arch/arm/mach-ux500/id.c
> @@ -17,7 +17,10 @@
> #include <mach/hardware.h>
> #include <mach/setup.h>
>
> +#include <linux/module.h>
> +
> struct dbx500_asic_id dbx500_id;
> +EXPORT_SYMBOL(dbx500_id);
>
> static unsigned int ux500_read_asicid(phys_addr_t addr)
> {
This needs an explanation! Why do you export an internal data structure
to non-GPL modules?
On a more general topic, I wonder if it's really necessary to add new
devices to the legacy probing path in mach-ux500. Why not make new drivers
for this platform dt-only, so we don't need to add code now that we will
have to remove again in one or two kernel releases?
Arnd
next prev parent reply other threads:[~2012-05-08 19:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 11:28 [PATCH 0/2] Update for ux500 CRYP and HASH Andreas Westin
2012-05-08 11:28 ` [PATCH 1/2] mach-ux500: Crypto: core support for CRYP/HASH module Andreas Westin
2012-05-08 19:37 ` Arnd Bergmann [this message]
2012-05-09 8:36 ` Linus Walleij
2012-05-09 8:51 ` Andreas WESTIN
2012-05-09 12:17 ` Arnd Bergmann
2012-05-09 13:09 ` Linus Walleij
2012-05-09 13:18 ` Andreas WESTIN
2012-05-09 13:47 ` Arnd Bergmann
2012-05-09 13:59 ` Andreas WESTIN
2012-05-08 11:28 ` [PATCH 2/2] crypto: ux500: Update DMA handling for 3.4 Andreas Westin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205081937.24450.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andreas.westin@stericsson.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=lee.jones@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).