From: Andi Kleen <andi@firstfloor.org>
To: Johannes Goetzfried
<Johannes.Goetzfried@informatik.stud.uni-erlangen.de>
Cc: "Jussi Kivilinna" <jussi.kivilinna@mbnet.fi>,
"Andi Kleen" <andi@firstfloor.org>,
"Herbert Xu" <herbert@gondor.hengli.com.au>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
"Tilo Müller" <Tilo.Mueller@informatik.uni-erlangen.de>
Subject: Re: [PATCH] crypto: serpent - add x86_64/avx assembler implementation
Date: Wed, 30 May 2012 17:39:49 +0200 [thread overview]
Message-ID: <20120530153949.GS27374@one.firstfloor.org> (raw)
In-Reply-To: <20120530113235.GO17705@kronos.redsun>
> I agree with that. Currently when I boot my PC with a new 3.4 kernel all the
> ciphers from the intel-aesni module get loaded whether I need them or not. As
> Jussi stated most people using distros probably won't need the
> serpent-avx-x86_64 module get loaded automatically, so it's probably better to
> leave it that way.
That means you got a 50% chance to use the wrong serpent.
This was a continuous problem with AESNI and the accelerated CRC,
that is why the cpuid probing was implemented.
Without some form of auto probing you may as well not bother with
the optimization.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2012-05-30 15:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 14:51 [PATCH] crypto: serpent - add x86_64/avx assembler implementation Johannes Goetzfried
2012-05-28 6:37 ` Jussi Kivilinna
2012-05-28 14:10 ` Johannes Goetzfried
2012-05-28 21:33 ` Jussi Kivilinna
2012-05-30 2:27 ` Andi Kleen
2012-05-30 7:30 ` Jussi Kivilinna
2012-05-30 11:32 ` Johannes Goetzfried
2012-05-30 15:39 ` Andi Kleen [this message]
2012-05-30 17:36 ` Johannes Goetzfried
2012-05-30 18:53 ` Jussi Kivilinna
2012-06-09 14:50 ` [PATCH] crypto: aes - make assembler implementation default for i386 and x86-64 Jussi Kivilinna
2012-06-12 8:26 ` Herbert Xu
2012-06-12 18:25 ` Jussi Kivilinna
2012-06-18 9:02 ` Herbert Xu
2012-06-20 11:49 ` Jussi Kivilinna
2012-05-30 21:29 ` [PATCH] crypto: serpent - add x86_64/avx assembler implementation Herbert Xu
2012-05-30 21:40 ` Andi Kleen
2012-05-30 21:44 ` Herbert Xu
2012-05-30 21:55 ` Andi Kleen
2012-05-30 22:34 ` Herbert Xu
2012-05-30 11:36 ` Johannes Goetzfried
2012-05-30 16:26 ` Andi Kleen
2012-05-30 17:49 ` Johannes Goetzfried
-- strict thread matches above, loose matches on Subject: below --
2012-05-28 14:12 Johannes Goetzfried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530153949.GS27374@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=Johannes.Goetzfried@informatik.stud.uni-erlangen.de \
--cc=Tilo.Mueller@informatik.uni-erlangen.de \
--cc=herbert@gondor.hengli.com.au \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).