From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Johannes Goetzfried
<Johannes.Goetzfried@informatik.stud.uni-erlangen.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: twofish-avx - remove useless instruction
Date: Thu, 5 Jul 2012 20:46:12 -0300 [thread overview]
Message-ID: <20120705234612.GD29301@khazad-dum.debian.net> (raw)
In-Reply-To: <20120705184358.GE2091@kronos.redsun>
On Thu, 05 Jul 2012, Johannes Goetzfried wrote:
> The register %rdx is written, but never read till the end of the encryption
> routine. Therefore let's delete the useless instruction.
Is it useless, or is it there to harden against some side-channel
attack?
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2012-07-05 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 18:43 [PATCH] crypto: twofish-avx - remove useless instruction Johannes Goetzfried
2012-07-05 23:46 ` Henrique de Moraes Holschuh [this message]
2012-07-06 0:13 ` Johannes Goetzfried
2012-07-11 3:26 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705234612.GD29301@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=Johannes.Goetzfried@informatik.stud.uni-erlangen.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox