From: Herbert Xu <herbert@gondor.apana.org.au>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Michael Ellerman <michael@ellerman.id.au>,
linux-crypto@vger.kernel.org, linuxppc-dev@ozlabs.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] powerpc/crypto: Remove virt_to_abs() usage in nx-842.c
Date: Mon, 20 Aug 2012 16:31:30 +0800 [thread overview]
Message-ID: <20120820083130.GB22951@gondor.apana.org.au> (raw)
In-Reply-To: <501BE2F6.5080506@linux.vnet.ibm.com>
On Fri, Aug 03, 2012 at 09:40:54AM -0500, Seth Jennings wrote:
> On 08/02/2012 09:23 PM, Michael Ellerman wrote:
> > virt_to_abs() is just a wrapper around __pa(), use __pa() directly.
> >
> > We should be including <asm/page.h> to get __pa(). abs_addr.h will be
> > removed shortly so drop that.
> >
> > We were getting of.h via abs_addr.h so we need to include that directly.
> >
> > Having done all that, clean up the ordering of the includes.
> >
> > Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> > ---
> > drivers/crypto/nx/nx-842.c | 34 ++++++++++++++++++----------------
> > 1 file changed, 18 insertions(+), 16 deletions(-)
>
> Looks good here. Thanks for doing this!
>
> Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Patch applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2012-08-20 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 2:23 [PATCH] powerpc/crypto: Remove virt_to_abs() usage in nx-842.c Michael Ellerman
2012-08-03 2:32 ` Michael Ellerman
2012-08-03 14:40 ` Seth Jennings
2012-08-20 8:31 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820083130.GB22951@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=benh@kernel.crashing.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox