From: Herbert Xu <herbert@gondor.apana.org.au>
To: David Miller <davem@davemloft.net>
Cc: jussi.kivilinna@mbnet.fi, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: cast5/cast6 - move lookup tables to shared module
Date: Thu, 6 Dec 2012 17:19:03 +0800 [thread overview]
Message-ID: <20121206091903.GA15870@gondor.apana.org.au> (raw)
In-Reply-To: <20121113.145246.1782542703964753357.davem@davemloft.net>
On Tue, Nov 13, 2012 at 02:52:46PM -0500, David Miller wrote:
> From: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
> Date: Tue, 13 Nov 2012 21:50:20 +0200
>
> > Quoting David Miller <davem@davemloft.net>:
> >
> >> From: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
> >> Date: Tue, 13 Nov 2012 11:43:14 +0200
> >>
> >>> CAST5 and CAST6 both use same lookup tables, which can be moved shared
> >>> module
> >>> 'cast_common'.
> >>>
> >>> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
> >>
> >> Does this work if you make CAST5 modular and CAST6 static, or vice
> >> versa?
> >>
> >
> > Yes, dependencies force common module to be built-in/static in both
> > cases and will be build as module only if both cast5 and cast6 are
> > also.
>
> Fair enough:
>
> Acked-by: David S. Miller <davem@davemloft.net>
Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2012-12-06 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 9:43 [PATCH] crypto: cast5/cast6 - move lookup tables to shared module Jussi Kivilinna
2012-11-13 18:53 ` David Miller
2012-11-13 19:50 ` Jussi Kivilinna
2012-11-13 19:52 ` David Miller
2012-12-06 9:19 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206091903.GA15870@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox