* [PATCH 7/15] drivers/crypto/atmel-aes.c: adjust duplicate test
[not found] <1358773378-4700-1-git-send-email-Julia.Lawall@lip6.fr>
@ 2013-01-21 13:02 ` Julia Lawall
2013-01-21 18:19 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2013-01-21 13:02 UTC (permalink / raw)
To: Herbert Xu; +Cc: kernel-janitors, David S. Miller, linux-crypto, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Delete successive tests to the same location. The code tested the result
of a previous allocation, that itself was already tested. It is changed to
test the result of the most recent allocation.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@s exists@
local idexpression y;
expression x,e;
@@
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/crypto/atmel-aes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
index c9d9d5c..6f22ba5 100644
--- a/drivers/crypto/atmel-aes.c
+++ b/drivers/crypto/atmel-aes.c
@@ -332,7 +332,7 @@ static int atmel_aes_crypt_cpu_start(struct atmel_aes_dev *dd)
return -EINVAL;
dd->nb_out_sg = atmel_aes_sg_length(dd->req, dd->out_sg);
- if (!dd->nb_in_sg)
+ if (!dd->nb_out_sg)
return -EINVAL;
dd->bufcnt = sg_copy_to_buffer(dd->in_sg, dd->nb_in_sg,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 7/15] drivers/crypto/atmel-aes.c: adjust duplicate test
2013-01-21 13:02 ` [PATCH 7/15] drivers/crypto/atmel-aes.c: adjust duplicate test Julia Lawall
@ 2013-01-21 18:19 ` David Miller
2013-02-04 13:21 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2013-01-21 18:19 UTC (permalink / raw)
To: Julia.Lawall; +Cc: herbert, kernel-janitors, linux-crypto, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Mon, 21 Jan 2013 14:02:51 +0100
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Delete successive tests to the same location. The code tested the result
> of a previous allocation, that itself was already tested. It is changed to
> test the result of the most recent allocation.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 7/15] drivers/crypto/atmel-aes.c: adjust duplicate test
2013-01-21 18:19 ` David Miller
@ 2013-02-04 13:21 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2013-02-04 13:21 UTC (permalink / raw)
To: David Miller; +Cc: Julia.Lawall, kernel-janitors, linux-crypto, linux-kernel
On Mon, Jan 21, 2013 at 01:19:12PM -0500, David Miller wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> Date: Mon, 21 Jan 2013 14:02:51 +0100
>
> > From: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > Delete successive tests to the same location. The code tested the result
> > of a previous allocation, that itself was already tested. It is changed to
> > test the result of the most recent allocation.
> >
> > A simplified version of the semantic match that finds this problem is as
> > follows: (http://coccinelle.lip6.fr/)
> ...
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Acked-by: David S. Miller <davem@davemloft.net>
Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-04 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1358773378-4700-1-git-send-email-Julia.Lawall@lip6.fr>
2013-01-21 13:02 ` [PATCH 7/15] drivers/crypto/atmel-aes.c: adjust duplicate test Julia Lawall
2013-01-21 18:19 ` David Miller
2013-02-04 13:21 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).