From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stoica Cristian-B18196 <B18196@freescale.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geanta Neag Horia Ioan-B05471 <B05471@freescale.com>
Subject: Re: [PATCH] crypto: remove double execution of the same test suite
Date: Thu, 1 Aug 2013 21:37:47 +1000 [thread overview]
Message-ID: <20130801113747.GA30622@gondor.apana.org.au> (raw)
In-Reply-To: <1628287275CAA9409F1E349DEF3C6CCE4D31E1@039-SN2MPN1-013.039d.mgd.msft.net>
On Thu, Aug 01, 2013 at 08:11:25AM +0000, Stoica Cristian-B18196 wrote:
> > Which algorithm (apart from crc* which I know and will fix) uses the
> > same driver name as its algorithm name? Doing this will cause issues
> > when an alternative implementation for that algorithm gets added.
>
> Fixing names resolves double calls only for the thread cryptomgr_test->alg_test where the call is:
> err = alg_test(param->driver, param->alg, type, CRYPTO_ALG_TESTED);
>
> It doesn't fix the thread tcrypt_test->alg_test where the call is:
> ret = alg_test(alg, alg, 0, 0);
Good point. I'll apply your patch.
Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2013-08-01 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 15:57 [PATCH] crypto: remove double execution of the same test suite Cristian Stoica
2013-07-19 6:48 ` Horia Geantă
2013-07-19 6:52 ` Gupta Ruchika-R66431
2013-07-31 15:00 ` Stoica Cristian-B18196
2013-08-01 0:47 ` Herbert Xu
2013-08-01 8:11 ` Stoica Cristian-B18196
2013-08-01 11:37 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801113747.GA30622@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=B05471@freescale.com \
--cc=B18196@freescale.com \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox