From: Herbert Xu <herbert@gondor.apana.org.au>
To: Fionnuala Gunter <fin@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, mhcerri@linux.vnet.ibm.com
Subject: Re: [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor
Date: Fri, 9 Aug 2013 16:43:37 +1000 [thread overview]
Message-ID: <20130809064337.GC23834@gondor.apana.org.au> (raw)
In-Reply-To: <1375917350.16050.14.camel@what-is-leg>
On Wed, Aug 07, 2013 at 06:15:50PM -0500, Fionnuala Gunter wrote:
> This patch fixes a bug that is triggered when cts(cbc(aes)) is used with
> nx-crypto driver on input larger than 32 bytes.
>
> The chaining value from co-processor was not being saved. This value is
> needed because it is used as the IV by cts(cbc(aes)).
>
> Signed-off-by: Fionnuala Gunter <fin@linux.vnet.ibm.com>
> Reviewed-by: Marcelo Cerri <mhcerri@linux.vnet.ibm.com>
> ---
> v2. changed signed-off-by to reviewed-by and added more details to
> description
>
> This bug appeared in the original submission (v3.5)
Patch applied. However your patch was totally white-space damaged.
I've fixed it this time, but please fix this in your future
submissions.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2013-08-09 6:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 23:15 [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor Fionnuala Gunter
2013-08-08 7:49 ` Michael Ellerman
2013-08-09 6:25 ` Benjamin Herrenschmidt
2013-08-09 6:30 ` Herbert Xu
2013-08-09 6:43 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809064337.GC23834@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=fin@linux.vnet.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhcerri@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox