* [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu()
@ 2013-08-20 3:43 Chen Gang
2013-08-20 3:44 ` Chen Gang
0 siblings, 1 reply; 13+ messages in thread
From: Chen Gang @ 2013-08-20 3:43 UTC (permalink / raw)
To: steffen.klassert; +Cc: linux-crypto, linux-kernel@vger.kernel.org
When failure occures, __padata_add_cpu() and __padata_remove_cpu() will
return -ENOMEM, which need be noticed in any cases (even in cleaning up
cases).
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
kernel/padata.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index 072f4ee..6a124cd 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -871,16 +871,20 @@ static int padata_cpu_callback(struct notifier_block *nfb,
if (!pinst_has_cpu(pinst, cpu))
break;
mutex_lock(&pinst->lock);
- __padata_remove_cpu(pinst, cpu);
+ err = __padata_remove_cpu(pinst, cpu);
mutex_unlock(&pinst->lock);
+ if (err)
+ return notifier_from_errno(err);
case CPU_DOWN_FAILED:
case CPU_DOWN_FAILED_FROZEN:
if (!pinst_has_cpu(pinst, cpu))
break;
mutex_lock(&pinst->lock);
- __padata_add_cpu(pinst, cpu);
+ err = __padata_add_cpu(pinst, cpu);
mutex_unlock(&pinst->lock);
+ if (err)
+ return notifier_from_errno(err);
}
return NOTIFY_OK;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu()
2013-08-20 3:43 [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu() Chen Gang
@ 2013-08-20 3:44 ` Chen Gang
2013-08-22 5:11 ` Steffen Klassert
0 siblings, 1 reply; 13+ messages in thread
From: Chen Gang @ 2013-08-20 3:44 UTC (permalink / raw)
To: steffen.klassert; +Cc: linux-crypto, linux-kernel@vger.kernel.org
If this patch is correct, better to let CPU_ONLINE and CPU_DOWN_FAILED
share the same code.
And do we need a comment "/* fall through */" between CPU_UP_CANCELED
and CPU_DOWN_FAILED (or it is another bug, need a 'break' statement) ?
At last, also better to let CPU_DOWN_PREPARE and CPU_UP_CANCELED share
the same code (if need a 'break'), or share the most of code (if "fall
through").
Thanks.
On 08/20/2013 11:43 AM, Chen Gang wrote:
> When failure occures, __padata_add_cpu() and __padata_remove_cpu() will
> return -ENOMEM, which need be noticed in any cases (even in cleaning up
> cases).
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> kernel/padata.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/padata.c b/kernel/padata.c
> index 072f4ee..6a124cd 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -871,16 +871,20 @@ static int padata_cpu_callback(struct notifier_block *nfb,
> if (!pinst_has_cpu(pinst, cpu))
> break;
> mutex_lock(&pinst->lock);
> - __padata_remove_cpu(pinst, cpu);
> + err = __padata_remove_cpu(pinst, cpu);
> mutex_unlock(&pinst->lock);
> + if (err)
> + return notifier_from_errno(err);
>
> case CPU_DOWN_FAILED:
> case CPU_DOWN_FAILED_FROZEN:
> if (!pinst_has_cpu(pinst, cpu))
> break;
> mutex_lock(&pinst->lock);
> - __padata_add_cpu(pinst, cpu);
> + err = __padata_add_cpu(pinst, cpu);
> mutex_unlock(&pinst->lock);
> + if (err)
> + return notifier_from_errno(err);
> }
>
> return NOTIFY_OK;
>
--
Chen Gang
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu()
2013-08-20 3:44 ` Chen Gang
@ 2013-08-22 5:11 ` Steffen Klassert
2013-08-22 5:27 ` Chen Gang
0 siblings, 1 reply; 13+ messages in thread
From: Steffen Klassert @ 2013-08-22 5:11 UTC (permalink / raw)
To: Chen Gang; +Cc: linux-crypto, linux-kernel@vger.kernel.org
On Tue, Aug 20, 2013 at 11:44:31AM +0800, Chen Gang wrote:
>
> If this patch is correct, better to let CPU_ONLINE and CPU_DOWN_FAILED
> share the same code.
>
> And do we need a comment "/* fall through */" between CPU_UP_CANCELED
> and CPU_DOWN_FAILED (or it is another bug, need a 'break' statement) ?
>
> At last, also better to let CPU_DOWN_PREPARE and CPU_UP_CANCELED share
> the same code (if need a 'break'), or share the most of code (if "fall
> through").
>
CPU_ONLINE and CPU_DOWN_FAILED can share the code. Same is true for
CPU_DOWN_PREPARE and CPU_UP_CANCELED.
Thanks!
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu()
2013-08-22 5:11 ` Steffen Klassert
@ 2013-08-22 5:27 ` Chen Gang
2013-08-22 6:05 ` Steffen Klassert
0 siblings, 1 reply; 13+ messages in thread
From: Chen Gang @ 2013-08-22 5:27 UTC (permalink / raw)
To: Steffen Klassert; +Cc: linux-crypto, linux-kernel@vger.kernel.org
On 08/22/2013 01:11 PM, Steffen Klassert wrote:
> On Tue, Aug 20, 2013 at 11:44:31AM +0800, Chen Gang wrote:
>>
>> If this patch is correct, better to let CPU_ONLINE and CPU_DOWN_FAILED
>> share the same code.
>>
>> And do we need a comment "/* fall through */" between CPU_UP_CANCELED
>> and CPU_DOWN_FAILED (or it is another bug, need a 'break' statement) ?
>>
>> At last, also better to let CPU_DOWN_PREPARE and CPU_UP_CANCELED share
>> the same code (if need a 'break'), or share the most of code (if "fall
>> through").
>>
>
> CPU_ONLINE and CPU_DOWN_FAILED can share the code. Same is true for
> CPU_DOWN_PREPARE and CPU_UP_CANCELED.
>
> Thanks!
>
>
Thank you too.
And need I send another patch for it ?
Or just make by yourself (and better to mark me as Reported-by). :-)
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu()
2013-08-22 5:27 ` Chen Gang
@ 2013-08-22 6:05 ` Steffen Klassert
2013-08-22 6:16 ` Chen Gang
2013-08-22 6:43 ` [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED Chen Gang
0 siblings, 2 replies; 13+ messages in thread
From: Steffen Klassert @ 2013-08-22 6:05 UTC (permalink / raw)
To: Chen Gang; +Cc: linux-crypto, linux-kernel@vger.kernel.org
On Thu, Aug 22, 2013 at 01:27:16PM +0800, Chen Gang wrote:
> On 08/22/2013 01:11 PM, Steffen Klassert wrote:
> > On Tue, Aug 20, 2013 at 11:44:31AM +0800, Chen Gang wrote:
> >>
> >> If this patch is correct, better to let CPU_ONLINE and CPU_DOWN_FAILED
> >> share the same code.
> >>
> >> And do we need a comment "/* fall through */" between CPU_UP_CANCELED
> >> and CPU_DOWN_FAILED (or it is another bug, need a 'break' statement) ?
> >>
> >> At last, also better to let CPU_DOWN_PREPARE and CPU_UP_CANCELED share
> >> the same code (if need a 'break'), or share the most of code (if "fall
> >> through").
> >>
> >
> > CPU_ONLINE and CPU_DOWN_FAILED can share the code. Same is true for
> > CPU_DOWN_PREPARE and CPU_UP_CANCELED.
> >
> > Thanks!
> >
> >
>
> Thank you too.
>
> And need I send another patch for it ?
>
> Or just make by yourself (and better to mark me as Reported-by). :-)
>
You found the problem, feel free to send a patch.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu()
2013-08-22 6:05 ` Steffen Klassert
@ 2013-08-22 6:16 ` Chen Gang
2013-08-22 6:43 ` [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED Chen Gang
1 sibling, 0 replies; 13+ messages in thread
From: Chen Gang @ 2013-08-22 6:16 UTC (permalink / raw)
To: Steffen Klassert; +Cc: linux-crypto, linux-kernel@vger.kernel.org
On 08/22/2013 02:05 PM, Steffen Klassert wrote:
> On Thu, Aug 22, 2013 at 01:27:16PM +0800, Chen Gang wrote:
>> On 08/22/2013 01:11 PM, Steffen Klassert wrote:
>>> On Tue, Aug 20, 2013 at 11:44:31AM +0800, Chen Gang wrote:
>>>>
>>>> If this patch is correct, better to let CPU_ONLINE and CPU_DOWN_FAILED
>>>> share the same code.
>>>>
>>>> And do we need a comment "/* fall through */" between CPU_UP_CANCELED
>>>> and CPU_DOWN_FAILED (or it is another bug, need a 'break' statement) ?
>>>>
>>>> At last, also better to let CPU_DOWN_PREPARE and CPU_UP_CANCELED share
>>>> the same code (if need a 'break'), or share the most of code (if "fall
>>>> through").
>>>>
>>>
>>> CPU_ONLINE and CPU_DOWN_FAILED can share the code. Same is true for
>>> CPU_DOWN_PREPARE and CPU_UP_CANCELED.
>>>
>>> Thanks!
>>>
>>>
>>
>> Thank you too.
>>
>> And need I send another patch for it ?
>>
>> Or just make by yourself (and better to mark me as Reported-by). :-)
>>
>
> You found the problem, feel free to send a patch.
>
>
Thanks, I will send patch v2 for it.
--
Chen Gang
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED
2013-08-22 6:05 ` Steffen Klassert
2013-08-22 6:16 ` Chen Gang
@ 2013-08-22 6:43 ` Chen Gang
2013-08-23 3:46 ` Chen Gang
2013-08-23 10:44 ` Steffen Klassert
1 sibling, 2 replies; 13+ messages in thread
From: Chen Gang @ 2013-08-22 6:43 UTC (permalink / raw)
To: Steffen Klassert; +Cc: linux-crypto, linux-kernel@vger.kernel.org
Share code between CPU_ONLINE and CPU_DOWN_FAILED, same to
CPU_DOWN_PREPARE and CPU_UP_CANCELED.
It will fix 2 bugs:
"not check the return value of __padata_remove_cpu() and __padata_add_cpu()".
"need add 'break' between CPU_UP_CANCELED and CPU_DOWN_FAILED".
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
kernel/padata.c | 20 ++++----------------
1 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index 072f4ee..2f0037a 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -846,6 +846,8 @@ static int padata_cpu_callback(struct notifier_block *nfb,
switch (action) {
case CPU_ONLINE:
case CPU_ONLINE_FROZEN:
+ case CPU_DOWN_FAILED:
+ case CPU_DOWN_FAILED_FROZEN:
if (!pinst_has_cpu(pinst, cpu))
break;
mutex_lock(&pinst->lock);
@@ -857,6 +859,8 @@ static int padata_cpu_callback(struct notifier_block *nfb,
case CPU_DOWN_PREPARE:
case CPU_DOWN_PREPARE_FROZEN:
+ case CPU_UP_CANCELED:
+ case CPU_UP_CANCELED_FROZEN:
if (!pinst_has_cpu(pinst, cpu))
break;
mutex_lock(&pinst->lock);
@@ -865,22 +869,6 @@ static int padata_cpu_callback(struct notifier_block *nfb,
if (err)
return notifier_from_errno(err);
break;
-
- case CPU_UP_CANCELED:
- case CPU_UP_CANCELED_FROZEN:
- if (!pinst_has_cpu(pinst, cpu))
- break;
- mutex_lock(&pinst->lock);
- __padata_remove_cpu(pinst, cpu);
- mutex_unlock(&pinst->lock);
-
- case CPU_DOWN_FAILED:
- case CPU_DOWN_FAILED_FROZEN:
- if (!pinst_has_cpu(pinst, cpu))
- break;
- mutex_lock(&pinst->lock);
- __padata_add_cpu(pinst, cpu);
- mutex_unlock(&pinst->lock);
}
return NOTIFY_OK;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED
2013-08-22 6:43 ` [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED Chen Gang
@ 2013-08-23 3:46 ` Chen Gang
2013-08-23 10:44 ` Steffen Klassert
1 sibling, 0 replies; 13+ messages in thread
From: Chen Gang @ 2013-08-23 3:46 UTC (permalink / raw)
To: Steffen Klassert; +Cc: linux-crypto, linux-kernel@vger.kernel.org
On 08/22/2013 02:43 PM, Chen Gang wrote:
> Share code between CPU_ONLINE and CPU_DOWN_FAILED, same to
> CPU_DOWN_PREPARE and CPU_UP_CANCELED.
>
> It will fix 2 bugs:
>
> "not check the return value of __padata_remove_cpu() and __padata_add_cpu()".
> "need add 'break' between CPU_UP_CANCELED and CPU_DOWN_FAILED".
>
Do we need more details descriptions ?
If so, could Steffen give more expert details information ?
Thanks.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> kernel/padata.c | 20 ++++----------------
> 1 files changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/kernel/padata.c b/kernel/padata.c
> index 072f4ee..2f0037a 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -846,6 +846,8 @@ static int padata_cpu_callback(struct notifier_block *nfb,
> switch (action) {
> case CPU_ONLINE:
> case CPU_ONLINE_FROZEN:
> + case CPU_DOWN_FAILED:
> + case CPU_DOWN_FAILED_FROZEN:
> if (!pinst_has_cpu(pinst, cpu))
> break;
> mutex_lock(&pinst->lock);
> @@ -857,6 +859,8 @@ static int padata_cpu_callback(struct notifier_block *nfb,
>
> case CPU_DOWN_PREPARE:
> case CPU_DOWN_PREPARE_FROZEN:
> + case CPU_UP_CANCELED:
> + case CPU_UP_CANCELED_FROZEN:
> if (!pinst_has_cpu(pinst, cpu))
> break;
> mutex_lock(&pinst->lock);
> @@ -865,22 +869,6 @@ static int padata_cpu_callback(struct notifier_block *nfb,
> if (err)
> return notifier_from_errno(err);
> break;
> -
> - case CPU_UP_CANCELED:
> - case CPU_UP_CANCELED_FROZEN:
> - if (!pinst_has_cpu(pinst, cpu))
> - break;
> - mutex_lock(&pinst->lock);
> - __padata_remove_cpu(pinst, cpu);
> - mutex_unlock(&pinst->lock);
> -
> - case CPU_DOWN_FAILED:
> - case CPU_DOWN_FAILED_FROZEN:
> - if (!pinst_has_cpu(pinst, cpu))
> - break;
> - mutex_lock(&pinst->lock);
> - __padata_add_cpu(pinst, cpu);
> - mutex_unlock(&pinst->lock);
> }
>
> return NOTIFY_OK;
>
--
Chen Gang
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED
2013-08-22 6:43 ` [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED Chen Gang
2013-08-23 3:46 ` Chen Gang
@ 2013-08-23 10:44 ` Steffen Klassert
2013-08-23 10:47 ` Herbert Xu
2013-08-29 4:42 ` Herbert Xu
1 sibling, 2 replies; 13+ messages in thread
From: Steffen Klassert @ 2013-08-23 10:44 UTC (permalink / raw)
To: Chen Gang, Herbert Xu; +Cc: linux-crypto, linux-kernel@vger.kernel.org
On Thu, Aug 22, 2013 at 02:43:37PM +0800, Chen Gang wrote:
> Share code between CPU_ONLINE and CPU_DOWN_FAILED, same to
> CPU_DOWN_PREPARE and CPU_UP_CANCELED.
>
> It will fix 2 bugs:
>
> "not check the return value of __padata_remove_cpu() and __padata_add_cpu()".
> "need add 'break' between CPU_UP_CANCELED and CPU_DOWN_FAILED".
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
This looks ok to me, Herbert can you take this one?
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED
2013-08-23 10:44 ` Steffen Klassert
@ 2013-08-23 10:47 ` Herbert Xu
2013-08-26 1:11 ` Chen Gang
2013-08-29 4:42 ` Herbert Xu
1 sibling, 1 reply; 13+ messages in thread
From: Herbert Xu @ 2013-08-23 10:47 UTC (permalink / raw)
To: Steffen Klassert; +Cc: Chen Gang, linux-crypto, linux-kernel@vger.kernel.org
On Fri, Aug 23, 2013 at 12:44:48PM +0200, Steffen Klassert wrote:
> On Thu, Aug 22, 2013 at 02:43:37PM +0800, Chen Gang wrote:
> > Share code between CPU_ONLINE and CPU_DOWN_FAILED, same to
> > CPU_DOWN_PREPARE and CPU_UP_CANCELED.
> >
> > It will fix 2 bugs:
> >
> > "not check the return value of __padata_remove_cpu() and __padata_add_cpu()".
> > "need add 'break' between CPU_UP_CANCELED and CPU_DOWN_FAILED".
> >
> >
> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>
> This looks ok to me, Herbert can you take this one?
Sure.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED
2013-08-23 10:47 ` Herbert Xu
@ 2013-08-26 1:11 ` Chen Gang
0 siblings, 0 replies; 13+ messages in thread
From: Chen Gang @ 2013-08-26 1:11 UTC (permalink / raw)
To: Herbert Xu; +Cc: Steffen Klassert, linux-crypto, linux-kernel@vger.kernel.org
On 08/23/2013 06:47 PM, Herbert Xu wrote:
> On Fri, Aug 23, 2013 at 12:44:48PM +0200, Steffen Klassert wrote:
>> On Thu, Aug 22, 2013 at 02:43:37PM +0800, Chen Gang wrote:
>>> Share code between CPU_ONLINE and CPU_DOWN_FAILED, same to
>>> CPU_DOWN_PREPARE and CPU_UP_CANCELED.
>>>
>>> It will fix 2 bugs:
>>>
>>> "not check the return value of __padata_remove_cpu() and __padata_add_cpu()".
>>> "need add 'break' between CPU_UP_CANCELED and CPU_DOWN_FAILED".
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>
>> This looks ok to me, Herbert can you take this one?
>
> Sure.
>
Thank you all.
> Thanks,
>
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED
2013-08-23 10:44 ` Steffen Klassert
2013-08-23 10:47 ` Herbert Xu
@ 2013-08-29 4:42 ` Herbert Xu
2013-08-29 5:22 ` Chen Gang
1 sibling, 1 reply; 13+ messages in thread
From: Herbert Xu @ 2013-08-29 4:42 UTC (permalink / raw)
To: Steffen Klassert; +Cc: Chen Gang, linux-crypto, linux-kernel@vger.kernel.org
On Fri, Aug 23, 2013 at 12:44:48PM +0200, Steffen Klassert wrote:
> On Thu, Aug 22, 2013 at 02:43:37PM +0800, Chen Gang wrote:
> > Share code between CPU_ONLINE and CPU_DOWN_FAILED, same to
> > CPU_DOWN_PREPARE and CPU_UP_CANCELED.
> >
> > It will fix 2 bugs:
> >
> > "not check the return value of __padata_remove_cpu() and __padata_add_cpu()".
> > "need add 'break' between CPU_UP_CANCELED and CPU_DOWN_FAILED".
> >
> >
> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>
> This looks ok to me, Herbert can you take this one?
>
> Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED
2013-08-29 4:42 ` Herbert Xu
@ 2013-08-29 5:22 ` Chen Gang
0 siblings, 0 replies; 13+ messages in thread
From: Chen Gang @ 2013-08-29 5:22 UTC (permalink / raw)
To: Herbert Xu; +Cc: Steffen Klassert, linux-crypto, linux-kernel@vger.kernel.org
On 08/29/2013 12:42 PM, Herbert Xu wrote:
> On Fri, Aug 23, 2013 at 12:44:48PM +0200, Steffen Klassert wrote:
>> On Thu, Aug 22, 2013 at 02:43:37PM +0800, Chen Gang wrote:
>>> Share code between CPU_ONLINE and CPU_DOWN_FAILED, same to
>>> CPU_DOWN_PREPARE and CPU_UP_CANCELED.
>>>
>>> It will fix 2 bugs:
>>>
>>> "not check the return value of __padata_remove_cpu() and __padata_add_cpu()".
>>> "need add 'break' between CPU_UP_CANCELED and CPU_DOWN_FAILED".
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>
>> This looks ok to me, Herbert can you take this one?
>>
>> Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
>
> Patch applied. Thanks!
>
Thank you too.
--
Chen Gang
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2013-08-29 5:23 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-20 3:43 [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu() Chen Gang
2013-08-20 3:44 ` Chen Gang
2013-08-22 5:11 ` Steffen Klassert
2013-08-22 5:27 ` Chen Gang
2013-08-22 6:05 ` Steffen Klassert
2013-08-22 6:16 ` Chen Gang
2013-08-22 6:43 ` [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED Chen Gang
2013-08-23 3:46 ` Chen Gang
2013-08-23 10:44 ` Steffen Klassert
2013-08-23 10:47 ` Herbert Xu
2013-08-26 1:11 ` Chen Gang
2013-08-29 4:42 ` Herbert Xu
2013-08-29 5:22 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).