From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2/3] ARM: mxs: crypto: Add Freescale MXS DCP driver
Date: Mon, 30 Sep 2013 00:09:50 +0200 [thread overview]
Message-ID: <201309300009.51084.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5A4rH_id25ROU_CdiOd79MhtU9J3jtFVyqeeD0R+=EuTw@mail.gmail.com>
Dear Fabio Estevam,
[...]
> > + * There can even be only one instance of the MXS DCP due to the
> > + * design of Linux Crypto API.
>
> Is this true? Usually we don't want to create a global struct.
Yeah, unfortunatelly :-(
>
> > +
> > +/* AES 128 ECB and AES 128 CBC */
> > +static struct crypto_alg dcp_aes_algs[] = {
> > + [0] = {
>
> No need for explicitely add this [0]
I wanted to be explicit here, but OK.
[...]
Rest is fixed, thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-29 22:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 11:18 [PATCH 1/3] crypto: Fully restore ahash request before completing Marek Vasut
2013-09-26 11:18 ` [PATCH 2/3] ARM: mxs: crypto: Add Freescale MXS DCP driver Marek Vasut
2013-09-26 11:27 ` Fabio Estevam
2013-09-26 12:07 ` Marek Vasut
2013-09-27 16:03 ` Tobias Rauter
2013-09-28 3:35 ` Marek Vasut
2013-10-07 9:50 ` Christoph G. Baumann
2013-10-07 15:48 ` Marek Vasut
2013-10-08 4:36 ` Herbert Xu
2013-10-08 10:33 ` Marek Vasut
2013-11-10 17:48 ` Marek Vasut
2013-11-20 11:20 ` Herbert Xu
2013-12-01 22:20 ` Marek Vasut
2013-09-26 12:13 ` Lothar Waßmann
2013-09-26 14:04 ` Marek Vasut
2013-09-26 14:09 ` Lothar Waßmann
2013-09-29 22:05 ` Marek Vasut
2013-09-26 12:37 ` Veli-Pekka Peltola
2013-09-26 14:02 ` Marek Vasut
2013-09-26 12:48 ` Fabio Estevam
2013-09-29 22:09 ` Marek Vasut [this message]
2013-09-26 11:18 ` [PATCH 3/3] ARM: mxs: dts: Enable DCP for MXS Marek Vasut
2013-09-26 11:36 ` Lothar Waßmann
2013-09-26 12:08 ` Marek Vasut
2013-09-29 22:11 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309300009.51084.marex@denx.de \
--to=marex@denx.de \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).