From: Will Deacon <will.deacon@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"patches@linaro.org" <patches@linaro.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"nico@linaro.org" <nico@linaro.org>
Subject: Re: [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes
Date: Fri, 4 Oct 2013 18:48:53 +0100 [thread overview]
Message-ID: <20131004174853.GY24303@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1380837566-18242-1-git-send-email-ard.biesheuvel@linaro.org>
Hi Ard,
On Thu, Oct 03, 2013 at 10:59:23PM +0100, Ard Biesheuvel wrote:
> Note to reviewers:
> Reviewing the file aesbs-core.S may be a bit overwhelming, so if there are any
> questions or concerns, please refer the file bsaes-armv7.pl which can be found
> at the link below. This is the original Perl script that gets called by
> OpenSSL's build system during their build to generate the .S file on the fly.
> [In the case of OpenSSL, this is used in some cases to target different
> assemblers or ABIs]. This arrangement is not suitable (or required) for the
> kernel, so I have taken the generated .S file instead.
>
> http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=6f6a6130
>
> This series still depends on commit a62b01cd (crypto: create generic version of
> ablk_helper) which I omitted this time but which can be found in the cryptodev
> tree or in linux-next.
Why do you consider it unsuitable to ship the perl script with the kernel?
Perl 5 is already documented as a build dependency in Documentation/Changes
and I'd *much* rather the .S file was generated rather than shipped and
hacked. That amount of opaque assembly code for something like crypto feels really
dangerous from both a review and a maintenance perspective.
Will
next prev parent reply other threads:[~2013-10-04 17:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 21:59 [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes Ard Biesheuvel
2013-10-03 21:59 ` [PATCH v2 1/3] ARM: pull in <asm/simd.h> from asm-generic Ard Biesheuvel
2013-10-03 21:59 ` [PATCH v2 2/3] ARM: move AES typedefs and function prototypes to separate header Ard Biesheuvel
2013-10-03 21:59 ` [PATCH v2 3/3] ARM: add support for bit sliced AES using NEON instructions Ard Biesheuvel
2013-10-04 0:38 ` Nicolas Pitre
2013-10-04 17:48 ` Will Deacon [this message]
2013-10-04 18:04 ` [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes Ard Biesheuvel
2013-10-04 18:23 ` Russell King - ARM Linux
2013-10-04 18:39 ` Nicolas Pitre
2013-10-04 18:34 ` Nicolas Pitre
2013-10-04 18:40 ` Russell King - ARM Linux
2013-10-04 18:41 ` Ard Biesheuvel
2013-10-04 18:46 ` Russell King - ARM Linux
2013-10-04 18:57 ` Nicolas Pitre
2013-10-04 18:54 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004174853.GY24303@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@linaro.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).