From: Steffen Klassert <steffen.klassert@secunet.com>
To: Mathias Krause <mathias.krause@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] padata: make the sequence counter an atomic_t
Date: Tue, 8 Oct 2013 14:08:24 +0200 [thread overview]
Message-ID: <20131008120824.GN7660@secunet.com> (raw)
In-Reply-To: <1380721245-5215-1-git-send-email-mathias.krause@secunet.com>
On Wed, Oct 02, 2013 at 03:40:45PM +0200, Mathias Krause wrote:
> Using a spinlock to atomically increase a counter sounds wrong -- we've
> atomic_t for this!
>
> Also move 'seq_nr' to a different cache line than 'lock' to reduce cache
> line trashing. This has the nice side effect of decreasing the size of
> struct parallel_data from 192 to 128 bytes for a x86-64 build, e.g.
> occupying only two instead of three cache lines.
>
> Those changes results in a 5% performance increase on an IPsec test run
> using pcrypt.
>
> Btw. the seq_lock spinlock was never explicitly initialized -- one more
> reason to get rid of it.
>
> Signed-off-by: Mathias Krause <mathias.krause@secunet.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Herbert can you take this one?
next prev parent reply other threads:[~2013-10-08 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 13:40 [PATCH] padata: make the sequence counter an atomic_t Mathias Krause
2013-10-08 12:08 ` Steffen Klassert [this message]
2013-10-25 8:20 ` Mathias Krause
2013-10-25 9:26 ` Herbert Xu
2013-10-25 10:13 ` Mathias Krause
2013-10-25 10:14 ` [PATCH RESEND] " Mathias Krause
2013-10-30 4:11 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008120824.GN7660@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=mathias.krause@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox